Skip to content

Commit c6b61ce

Browse files
authored
fix: update known issues related to orders with zero amounts (#262)
Related: cowprotocol/docs#624
1 parent c94c595 commit c6b61ce

1 file changed

Lines changed: 1 addition & 5 deletions

File tree

README.md

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -124,12 +124,8 @@ A summary of coverage results are printed out to console. More detailed informat
124124

125125
## Known issues
126126

127-
If a user creates an order with:
128-
- zero sell amount
129-
- zero buy amount
130-
- partially fillable set to false
127+
If a user creates an order with `sellAmount = 0` or `buyAmount = 0`, then this order could be executed an arbitrary amount of times instead of just a single time.
131128

132-
then this order could be executed an arbitrary amount of times instead of just a single time.
133129
This means that any solver could drain the fee amount from the user until not enough funds are available anymore.
134130

135131
We recommend to never sign orders of this form and, if developing a contract that creates orders on behalf of other users, make sure at a contract level that such orders cannot be created.

0 commit comments

Comments
 (0)