Skip to content

Fix invalid WETH address and wrong BNB explorer links in competition rules - #652

Open
KaiserSnipes wants to merge 1 commit into
cowprotocol:mainfrom
KaiserSnipes:fix/competition-rules-explorer-links
Open

Fix invalid WETH address and wrong BNB explorer links in competition rules#652
KaiserSnipes wants to merge 1 commit into
cowprotocol:mainfrom
KaiserSnipes:fix/competition-rules-explorer-links

Conversation

@KaiserSnipes

@KaiserSnipes KaiserSnipes commented Aug 8, 2026

Copy link
Copy Markdown

Description

Two link fixes in the competition rules baseline-token sections. The Base chain baseline links WETH to 0x420000000000000000000000000000000000000, which is 39 hex characters and not a valid address. The BNB chain baseline's four explorer links point at bnbscan.com rather than the canonical BNB Chain explorer (bscscan.com).

Changes

  • Base baseline: corrected the WETH link target to the canonical Base WETH 0x4200000000000000000000000000000000000006 (on-chain symbol() returns WETH).
  • BNB baseline: replaced bnbscan.com with bscscan.com in four links. The addresses themselves are unchanged.

Summary by CodeRabbit

  • Documentation
    • Updated the Base chain WETH address reference to the canonical address.
    • Corrected BNB chain token links to use BscScan.

…rules

- Base baseline: the WETH explorer link pointed to a 39-character
  (invalid) address; corrected to the canonical Base WETH
  0x4200000000000000000000000000000000000006 (on-chain symbol()
  returns WETH).
- BNB baseline: four explorer links pointed at bnbscan.com rather than
  the canonical BNB Chain explorer (bscscan.com). Addresses unchanged.
@KaiserSnipes
KaiserSnipes requested a review from a team as a code owner August 8, 2026 18:13
@vercel

vercel Bot commented Aug 8, 2026

Copy link
Copy Markdown

@KaiserSnipes is attempting to deploy a commit to the cow Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 31a9eaa2-553e-4a9b-97a6-0ee85938f286

📥 Commits

Reviewing files that changed from the base of the PR and between b5c361d and ef46752.

📒 Files selected for processing (1)
  • docs/cow-protocol/reference/core/auctions/competition_rules.md

📝 Walkthrough

Walkthrough

The competition rules documentation now uses the canonical Base WETH address and bscscan.com for BNB chain token links.

Changes

Token link corrections

Layer / File(s) Summary
Update chain token links
docs/cow-protocol/reference/core/auctions/competition_rules.md
The Base WETH link uses the canonical address ending in 0006. BNB token links use bscscan.com while preserving their addresses.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: harisang, pretf00d, raq0x

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes both link corrections made in the competition rules.
Description check ✅ Passed The description includes the required sections and clearly explains the reasons and details for each link correction.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@KaiserSnipes

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

github-actions Bot added a commit that referenced this pull request Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant