Merged
Conversation
jmg-duarte
added
the
hotfix
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
m-sz
approved these changes
Mar 31, 2026
squadgazzz
reviewed
Mar 31, 2026
| if let quote::Error::Solver(ref solver_err) = value | ||
| && let Some(custom_err) = solver_err.custom_error() | ||
| { | ||
| tracing::warn!(err=?custom_err, "received custom solver error, mapping to internal errors"); |
Contributor
There was a problem hiding this comment.
I would argue regarding the warn level. It is more of a debug-level log. In case you are not seeing this log in prod, you can enable it precisely using Unix sockets.
Please keep an eye on the amount of logs it produces in prod. But in any case, this shouldn't be a warning. Many solvers might respond with "invalid response", as we can already see that in the logs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a log for the custom error that the solver returned
Context: https://nomevlabs.slack.com/archives/C0375NV72SC/p1774966168341339?thread_ts=1774881240.020949&cid=C0375NV72SC
Changes
How to test
NA