Skip to content

Log custom solver errors on quoting #4301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmg-duarte merged 1 commit into from
Mar 31, 2026
Merged

Log custom solver errors on quoting #4301

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/driver/src/infra/api/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ impl From<quote::Error> for (axum::http::StatusCode, axum::Json<Error>) {
if let quote::Error::Solver(ref solver_err) = value
&& let Some(custom_err) = solver_err.custom_error()
{
tracing::warn!(err=?custom_err, "received custom solver error, mapping to internal errors");
Copy link
Copy Markdown
Contributor

@squadgazzz squadgazzz Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would argue regarding the warn level. It is more of a debug-level log. In case you are not seeing this log in prod, you can enable it precisely using Unix sockets.

Please keep an eye on the amount of logs it produces in prod. But in any case, this shouldn't be a warning. Many solvers might respond with "invalid response", as we can already see that in the logs.

let (kind, description) = map_custom_solver_error(custom_err);
return (
axum::http::StatusCode::BAD_REQUEST,
Expand Down
Loading