Skip to content

Fix JSON schema formatting#4634

Merged
MartinquaXD merged 1 commit into
mainfrom
jmgd/schemas
Jul 16, 2026
Merged

Fix JSON schema formatting#4634
MartinquaXD merged 1 commit into
mainfrom
jmgd/schemas

Conversation

@jmg-duarte

Copy link
Copy Markdown
Contributor

Description

The JSON schema job has been failing, this fixes it.

Changes

  • Regen OpenAPI schema

How to test

CI is green

@jmg-duarte
jmg-duarte requested a review from a team as a code owner July 16, 2026 14:15
@claude

claude Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Claude finished @jmg-duarte's task in 37s —— View job


PR Review

  • Read the diff
  • Verify schema matches source docstring
  • Post findings

LGTM.

The change updates the generated WinningPriceEstimateEvent description in events.json from "Exactly one is emitted..." to "At most one is emitted... (because all may have errored...)". This exactly matches the source docstring in crates/event-bus-dto/src/winning_price_estimate.rs:13-14, so the committed schema is now back in sync with the source — which is what the failing JSON schema check verifies.

No correctness or style concerns. Nothing to flag inline.

@MartinquaXD

Copy link
Copy Markdown
Contributor

How did the change slip past CI, though?

@jmg-duarte

Copy link
Copy Markdown
Contributor Author

How did the change slip past CI, though?

This PR broke it: https://github.com/cowprotocol/services/actions/runs/29087308408
Since the check wasn't required it got automerged before finishing

This feature allowed it to keep going: #4583 (comment)

@MartinquaXD

Copy link
Copy Markdown
Contributor

Shouldn't we make it required then?

@jmg-duarte

Copy link
Copy Markdown
Contributor Author

Done

@jmg-duarte
jmg-duarte added this pull request to the merge queue Jul 16, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 16, 2026
@MartinquaXD
MartinquaXD added this pull request to the merge queue Jul 16, 2026
Merged via the queue into main with commit d7d182a Jul 16, 2026
24 checks passed
@MartinquaXD
MartinquaXD deleted the jmgd/schemas branch July 16, 2026 15:01
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants