Create columns to track settlement gas info - #4697
Conversation
|
Reminder: Please update the DB Readme and comment whether migrations are reversible (include rollback scripts if applicable).
Caused by: |
|
Claude finished @jmg-duarte's task in 1m 7s —— View job PR Review: Settlement gas info columns
The migration looks solid — additive nullable columns with Two small points posted inline:
Neither is blocking. |
| ALTER TABLE settlements | ||
| ADD COLUMN gas_used numeric(78, 0), | ||
| ADD COLUMN effective_gas_price numeric(78, 0); |
There was a problem hiding this comment.
The bot reminder asks to update the DB README when adding columns. The settlements table docs still don't list gas_used / effective_gas_price — worth adding the two rows so the schema doc stays in sync.
Type/naming look good: numeric(78,0) matches the u256 convention used elsewhere (and the existing gas_used numeric(78,0) in V048__create_settlement_rewards.sql), and nullable additive columns are backward-compatible with the k8s rollout overlap.
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
MartinquaXD
left a comment
There was a problem hiding this comment.
Probably makes sense to keep the columns separately for higher flexibility but do we currently plan on using those values separately?
Description
#4540 requires that the migration is done first to avoid issues when upping it in K8s
This PR adds the settlement gas info columns to the settlement table.
Changes
gas_usedcolumn tosettlementtableeffective_gas_pricetosettlementtable