Refactor: cleanup before updating FinalizeSettle#58
Open
fedgiac wants to merge 1 commit into
Open
Conversation
kaze-cow
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small changes that I did while writing PR #47 that can stand alone.
I separated them to make that PR smaller. (It's still quite large unfortunately.)
Nothing in this PR changes the behavior of any code or test.
Changes
SettledOrdertoInitializedIntent. This is because we're going to introduceFinalizedIntent, which serves a similar role and would be more fitting for the nameSettledOrderanyway but loses the symmetry withInitializedIntent.ix_data!is used more in some of the BeginSettle encoding tests.Drop a redundant re-exportinterface/src/instruction/settle/mod.rsre-exportedSettledOrders, but nothing outside the module refers to it — it's only ever used internally as the type ofBeginSettleInput::orders. Removed it from thepub useline.How to test
CI.
You can also do
git diff --find-renames --color-moved HEAD~1to see from the color coding that the new file is mostly copied lines apart from comments andpub.