-
Notifications
You must be signed in to change notification settings - Fork 29
Release 2.1.0 #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Release 2.1.0 #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are still WIP, need to push them to default repo branch to test them on GH actions
* Some renamings * Added label to text area forms * Installing imagemagick and uploading resulting image to access it outside * Whole bunch of stuff, mostly addImage complete Still WIP, need to test it on GH actions
Local `act` is way less fussy about this. I hope it would warn me about this kind of issue.
Also updated addImage PR body
* Added python helper for updating the token list and token info * Added workflow job for handling addToken request
peter-evans/create-pull-request#1638 Will come back if there's any progress in that issue
* Optimized mainnet images * Optimized gnosis chain images * Optimized more mainnet images * Reseted some images and manually adjusted them
Summary: should have used OR instead of AND
* Restructured image folders * Adding the script used to restructure the folder for future reference
* Updated readme with instructions using the new forms * Added mermaid form with the flow overview
Co-authored-by: cmagan <cmagan@users.noreply.github.com>
* Use number type for token decimals * Fix workflow using string for newly created token decimals
* [addToken] MAINNET/0x19062190B1925b5b6689D7073fDfC8c2976EF8Cb * Fixing decimals saved as string instead of number --------- Co-authored-by: tonytony32 <tonytony32@users.noreply.github.com> Co-authored-by: Leandro Boscariol <alfetopito@users.noreply.github.com>
Co-authored-by: openb0x <openb0x@users.noreply.github.com>
Co-authored-by: avsavsavs <avsavsavs@users.noreply.github.com>
alfetopito
commented
Mar 22, 2023
Comment on lines
+560
to
+590
| { | ||
| "address": "0xfcf8eda095e37a41e002e266daad7efc1579bc0a", | ||
| "symbol": "FLEX", | ||
| "name": "Flex Coin", | ||
| "decimals": 18, | ||
| "chainId": 1, | ||
| "logoURI": "https://raw.githubusercontent.com/cowprotocol/token-lists/main/src/public/images/1/0xfcf8eda095e37a41e002e266daad7efc1579bc0a/logo.png" | ||
| }, | ||
| { | ||
| "address": "0x19062190b1925b5b6689d7073fdfc8c2976ef8cb", | ||
| "symbol": "BZZ", | ||
| "name": "Swarm", | ||
| "decimals": 16, | ||
| "chainId": 1, | ||
| "logoURI": "https://raw.githubusercontent.com/cowprotocol/token-lists/main/src/public/images/1/0x19062190B1925b5b6689D7073fDfC8c2976EF8Cb/logo.png" | ||
| }, | ||
| { | ||
| "address": "0xe95a203b1a91a908f9b9ce46459d101078c2c3cb", | ||
| "symbol": "ankrETH", | ||
| "name": "Ankr Staked ETH", | ||
| "decimals": 18, | ||
| "chainId": 1, | ||
| "logoURI": "https://raw.githubusercontent.com/cowprotocol/token-lists/main/src/public/images/1/0xE95A203B1a91a908F9B9CE46459d101078c2c3cb/logo.png" | ||
| }, | ||
| { | ||
| "address": "0xb50721bcf8d664c30412cfbc6cf7a15145234ad1", | ||
| "symbol": "ARB", | ||
| "name": "Arbitrum Token", | ||
| "decimals": 18, | ||
| "chainId": 1, | ||
| "logoURI": "https://raw.githubusercontent.com/cowprotocol/token-lists/main/src/public/images/1/0xB50721BCf8d664c30412Cfbc6cf7a15145234ad1/logo.png" |
Collaborator
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the effective token list changes
Merged
Collaborator
Author
|
Superseded by #129 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Released latest batch of tokens with a new version
Plus all of the GH actions logic for automating token ingestion