Skip to content

Conversation

@alfetopito
Copy link
Collaborator

Summary

Supersedes #128

Released latest batch of tokens with a new version
Plus all of the GH actions logic for automating token ingestion

They are still WIP, need to push them to default repo branch to test them on GH actions
* Some renamings

* Added label to text area forms

* Installing imagemagick and uploading resulting image to access it outside

* Whole bunch of stuff, mostly addImage complete

Still WIP, need to test it on GH actions
Local `act` is way less fussy about this.
I hope it would warn me about this kind of issue.
* Added python helper for updating the token list and token info

* Added workflow job for handling addToken request
peter-evans/create-pull-request#1638

Will come back if there's any progress in that issue
* Optimized mainnet images

* Optimized gnosis chain images

* Optimized more mainnet images

* Reseted some images and manually adjusted them
Summary: should have used OR instead of AND
* Restructured image folders

* Adding the script used to restructure the folder for future reference
* Updated readme with instructions using the new forms

* Added mermaid form with the flow overview
github-actions bot and others added 6 commits March 7, 2023 05:10
Co-authored-by: cmagan <cmagan@users.noreply.github.com>
* Use number type for token decimals

* Fix workflow using string for newly created token decimals
* [addToken] MAINNET/0x19062190B1925b5b6689D7073fDfC8c2976EF8Cb

* Fixing decimals saved as string instead of number

---------

Co-authored-by: tonytony32 <tonytony32@users.noreply.github.com>
Co-authored-by: Leandro Boscariol <alfetopito@users.noreply.github.com>
Co-authored-by: openb0x <openb0x@users.noreply.github.com>
Co-authored-by: avsavsavs <avsavsavs@users.noreply.github.com>
@alfetopito alfetopito mentioned this pull request Mar 22, 2023
@alfetopito alfetopito self-assigned this Mar 22, 2023
Comment on lines 5 to 7
"major": 2,
"minor": 0,
"minor": 1,
"patch": 0
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor version bump as we are only adding tokens. See https://github.com/Uniswap/token-lists#semantic-versioning

Comment on lines +561 to +590
"address": "0xfcf8eda095e37a41e002e266daad7efc1579bc0a",
"symbol": "FLEX",
"name": "Flex Coin",
"decimals": 18,
"chainId": 1,
"logoURI": "https://raw.githubusercontent.com/cowprotocol/token-lists/main/src/public/images/1/0xfcf8eda095e37a41e002e266daad7efc1579bc0a/logo.png"
},
{
"address": "0x19062190b1925b5b6689d7073fdfc8c2976ef8cb",
"symbol": "BZZ",
"name": "Swarm",
"decimals": 16,
"chainId": 1,
"logoURI": "https://raw.githubusercontent.com/cowprotocol/token-lists/main/src/public/images/1/0x19062190B1925b5b6689D7073fDfC8c2976EF8Cb/logo.png"
},
{
"address": "0xe95a203b1a91a908f9b9ce46459d101078c2c3cb",
"symbol": "ankrETH",
"name": "Ankr Staked ETH",
"decimals": 18,
"chainId": 1,
"logoURI": "https://raw.githubusercontent.com/cowprotocol/token-lists/main/src/public/images/1/0xE95A203B1a91a908F9B9CE46459d101078c2c3cb/logo.png"
},
{
"address": "0xb50721bcf8d664c30412cfbc6cf7a15145234ad1",
"symbol": "ARB",
"name": "Arbitrum Token",
"decimals": 18,
"chainId": 1,
"logoURI": "https://raw.githubusercontent.com/cowprotocol/token-lists/main/src/public/images/1/0xB50721BCf8d664c30412Cfbc6cf7a15145234ad1/logo.png"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tokens added

@alfetopito alfetopito requested a review from a team March 22, 2023 11:59
@alfetopito alfetopito merged commit 07df03a into main Mar 22, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2023
@alfetopito alfetopito deleted the release/2.1.0 branch July 6, 2023 13:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants