gw#421: generation smoke runs independently of suite outcome - #133
Merged
Conversation
Two consecutive live runs lost the smoke to the pre-existing tests/convert/test_streaming_convert.py::test_peak_anon_rss_below_2x_largest_tensor[cast_bf16] flake (peak anon RSS ~104-105MB vs 93.75MB bound; machine-sensitive — green on the 23:37 pod, red on the next two). The smoke is an independent product signal and now runs whenever deps synced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs 29060438735 and 29060632069 both failed on the pre-existing
test_peak_anon_rss_below_2x_largest_tensor[cast_bf16]RSS-bound flake (~104MB vs 93.75MB, machine-sensitive; it was green on the 23:37 pod), which skipped the generation smoke both times. The smoke is an independent "does the product make pictures" signal — gate it on deps-sync success instead of suite success (!cancelled() && steps.sync.outcome == 'success'). A garbled image still fails the job; the flaky suite test still fails the job; they just no longer mask each other.Not touched here: the RSS flake itself — noted in the gw#421 tracker section for follow-up.
🤖 Generated with Claude Code