Skip to content

fix(telemetry): use generic period names for quarter and year tabs#504

Merged
tym83 merged 1 commit intomainfrom
fix/telemetry-period-tab-labels
Apr 21, 2026
Merged

fix(telemetry): use generic period names for quarter and year tabs#504
tym83 merged 1 commit intomainfrom
fix/telemetry-period-tab-labels

Conversation

@tym83
Copy link
Copy Markdown
Contributor

@tym83 tym83 commented Apr 21, 2026

Summary

  • Quarter and Year tab labels on the Telemetry page (/oss-health/telemetry/) were showing date range strings (e.g. "March 2026 — April 2026") instead of stable period names
  • Changed label values in static/oss-health-data/telemetry.json to "Quarter" and "Year"

What

Updated periods.quarter.label and periods.year.label in the telemetry snapshot data.

Why

Date range strings make sense for the Month tab (which reflects the current month), but for Quarter and Year aggregates a static label is clearer and avoids showing a stale date range as data accumulates over time.

Preview

Tabs on https://cozystack.io/oss-health/telemetry/ will show: Month · Quarter · Year

Summary by CodeRabbit

  • Style
    • Simplified telemetry period labels from date-specific formats to generic terms ("Quarter" and "Year").

Quarter and Year tabs were showing date range strings instead of
stable period identifiers.

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: tym83 <6355522@gmail.com>
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 21, 2026

Deploy Preview for cozystack ready!

Name Link
🔨 Latest commit 9c2a10c
🔍 Latest deploy log https://app.netlify.com/projects/cozystack/deploys/69e752afabf2210008544999
😎 Deploy Preview https://deploy-preview-504--cozystack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 21, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7e5950e9-9b33-48d4-ad43-55ec01852623

📥 Commits

Reviewing files that changed from the base of the PR and between 6a684d0 and 9c2a10c.

📒 Files selected for processing (1)
  • static/oss-health-data/telemetry.json

📝 Walkthrough

Walkthrough

The telemetry.json configuration file was updated to replace specific date-range labels ("March 2026 — April 2026") with generic period labels ("Quarter" and "Year"), affecting two period entries while preserving all other structure and values.

Changes

Cohort / File(s) Summary
Telemetry Configuration
static/oss-health-data/telemetry.json
Updated periods.quarter.label and periods.year.label from date-specific ranges to generic period names.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Labels shift from dates so clear,
To generic terms we all can hear—
Quarter, Year, so bold and bright,
Telemetry shines with new delight!
A small hop forward, metrics lean,
The cleanest config I've ever seen!

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/telemetry-period-tab-labels

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request manually updates the 'quarter' and 'year' labels in the telemetry data JSON file. Feedback highlights that these manual changes will be overwritten by the automated fetch script and recommends updating the generation logic in hack/fetch_telemetry.py to ensure the generic labels persist.

},
"quarter": {
"label": "March 2026 — April 2026",
"label": "Quarter",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This manual update to the telemetry data will be overwritten by the hack/fetch_telemetry.py script during its next scheduled run (via .github/workflows/fetch-telemetry.yml).

To ensure these generic labels persist, the logic in hack/fetch_telemetry.py should be modified to prioritize the generic labels for the quarter and year periods. This would also align the telemetry data generation with the approach used in hack/update_oss_health.py.

You can modify the build_payload function in hack/fetch_telemetry.py as follows:

for key in ("month", "quarter", "year"):
    raw_p = periods_raw.get(key, {}) or {}
    if key in ("quarter", "year"):
        raw_p["label"] = key.title()
    transformed = transform_period(raw_p, label_fallback=key.title())

},
"year": {
"label": "March 2026 — April 2026",
"label": "Year",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Similar to the change on line 110, this manual update will be overwritten by the automated fetch script. Please update the generator logic in hack/fetch_telemetry.py to make this change permanent.

@tym83 tym83 marked this pull request as ready for review April 21, 2026 10:47
@tym83 tym83 requested review from kvaps and lllamnyp as code owners April 21, 2026 10:47
@tym83 tym83 merged commit 78f644b into main Apr 21, 2026
5 of 6 checks passed
@tym83 tym83 deleted the fix/telemetry-period-tab-labels branch April 21, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant