Skip to content

fix(telemetry): use generic period names for quarter and year tabs #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tym83 merged 1 commit into from
Apr 21, 2026
Merged

fix(telemetry): use generic period names for quarter and year tabs #504

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions static/oss-health-data/telemetry.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@
}
},
"quarter": {
"label": "March 2026 — April 2026",
"label": "Quarter",
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This manual update to the telemetry data will be overwritten by the hack/fetch_telemetry.py script during its next scheduled run (via .github/workflows/fetch-telemetry.yml).

To ensure these generic labels persist, the logic in hack/fetch_telemetry.py should be modified to prioritize the generic labels for the quarter and year periods. This would also align the telemetry data generation with the approach used in hack/update_oss_health.py.

You can modify the build_payload function in hack/fetch_telemetry.py as follows:

for key in ("month", "quarter", "year"):
    raw_p = periods_raw.get(key, {}) or {}
    if key in ("quarter", "year"):
        raw_p["label"] = key.title()
    transformed = transform_period(raw_p, label_fallback=key.title())

"summary_cards": [
{
"label": "Clusters",
Expand Down Expand Up @@ -220,7 +220,7 @@
}
},
"year": {
"label": "March 2026 — April 2026",
"label": "Year",
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Similar to the change on line 110, this manual update will be overwritten by the automated fetch script. Please update the generator logic in hack/fetch_telemetry.py to make this change permanent.

"summary_cards": [
{
"label": "Clusters",
Expand Down