-
Notifications
You must be signed in to change notification settings - Fork 8
cleanup: unused offset field in OverloadFTOps struct #64
Copy link
Copy link
Description
Problem
The OverloadFTOps struct declares int offset but this field is never read or written anywhere in the XS or header code. It is not referenced in any BOOT initializer, any operator handler, or any Perl-side function. There is also no comment explaining what it was intended for.
Why This Matters
Dead struct members cause confusion ("what is this for?"), waste memory (sizeof(int) per instance), and mislead anyone reading the code about the module's design. Since OverloadFTOps is allocated with Newxz (zero-initialised), removing the field is safe and trivially reversible.
Suggested Fix
Remove int offset; from the OverloadFTOps struct definition in FileCheck.h.
Details
| Severity | 🟢 Low |
| Category | cleanup |
| Location | FileCheck.h:22-24 |
| Effort | ⚡ Quick fix |
🤖 Created by Kōan from audit session
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels