cleanup: remove unused offset field from OverloadFTOps#78
Draft
Koan-Bot wants to merge 1 commit intocpan-authors:mainfrom
Draft
cleanup: remove unused offset field from OverloadFTOps#78Koan-Bot wants to merge 1 commit intocpan-authors:mainfrom
Koan-Bot wants to merge 1 commit intocpan-authors:mainfrom
Conversation
The `int offset` member was never read or written anywhere in the XS, header, or Perl code. Removing it reduces confusion and eliminates sizeof(int) of wasted memory per instance. Closes cpan-authors#64 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the unused
int offsetmember from theOverloadFTOpsstruct.Why
This field is never read or written anywhere — not in XS handlers, not in BOOT, not in Perl-side code. It wastes
sizeof(int)per instance and misleads readers about the module's design.How
Single-line deletion from
FileCheck.h. The struct is zero-initialized withNewxz, so removing the field is safe with no behavioral change.Testing
Full test suite passes (
make test). No code referencesoffsetoutside the struct definition.Closes #64
🤖 Generated with Claude Code