[thread] Exposition-only formatting for private members#8175
Merged
Conversation
frederick-vs-ja
force-pushed
the
expos-thread
branch
from
6eb32b6 to
f280a32
Compare
frederick-vs-ja
force-pushed
the
expos-thread
branch
from
f280a32 to
d04be04
Compare
wg21bot
added
the
needs rebase
frederick-vs-ja
force-pushed
the
expos-thread
branch
from
d04be04 to
1da29ad
Compare
Contributor
Author
|
@tkoeppe Squashed and rebased. |
Affected sections and exposition-only identifiers: [thread.jthread.class] - _`ssource`_ [atomics.ref.generic] - _`ptr`_ [util.smartptr.atomic.shared] - _`p`_ [util.smartptr.atomic.weak] - _`p`_ [thread.lock.guard] - _`pm`_ [thread.lock.scoped] - _`pm`_ [thread.lock.unique] - _`pm`_ - _`owns`_ [thread.lock.shared] - _`pm`_ - _`owns`_ [thread.sema.cnt] - _`counter`_ [thread.latch.class] - _`counter`_ [thread.barrier.class] - _`completion`_ [futures.future.error] - _`ec_`_ Drive-by changes: [atomics.ref.float] - Use `\placeholder` for _`floating-point-type`_
frederick-vs-ja
force-pushed
the
expos-thread
branch
from
1da29ad to
b738440
Compare
jensmaurer
removed
the
needs rebase
jensmaurer
approved these changes
Apr 21, 2026
jensmaurer
left a comment
jensmaurer
left a comment
Member
There was a problem hiding this comment.
I like this. More clarity which symbols are user-visible and which ones aren't.
Contributor
|
Yes, this is nice. @jensmaurer Have you reviewed this carefully already? |
Member
|
I have scrolled over the diff. I'm pretty certain it just sprinkles \exposid across the board (and sometimes, removes \tcode), but of course I haven't checked whether anything was overlooked. Even if it were, we can fix afterwards once the bulk is in. |
Contributor
|
Yeah, OK. I'll also try to take a closer look before merging then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #4702, #5940.
Affected sections and exposition-only identifiers:
[thread.jthread.class]
ssource[atomics.ref.generic]
ptr[util.smartptr.atomic.shared]
p[util.smartptr.atomic.weak]
p[thread.lock.guard]
pm[thread.lock.scoped]
pm[thread.lock.unique]
pmowns[thread.lock.shared]
pmowns[thread.sema.cnt]
counter[thread.latch.class]
counter[thread.barrier.class]
completion[futures.future.error]
ec_Drive-by changes:
[atomics.ref.float]
\placeholderforfloating-point-type