[iostream.forward.overview] Fix description for typedef-names, mention basic_spanbuf and its friends#8809
Merged
tkoeppe merged 2 commits intocplusplus:mainfrom Mar 26, 2026
Conversation
jwakely
reviewed
Mar 24, 2026
frederick-vs-ja
force-pushed
the
ios-typedef-names-no-def
branch
from
9b6330b to
178fc43
Compare
frederick-vs-ja
changed the title
basic_spanbuf and its friends
Member
|
Please make this two commits: One adding span-related stuff and one fixing the use of typedef-name. |
jensmaurer
added
the
changes requested
jensmaurer
requested changes
Mar 25, 2026
Member
jensmaurer
left a comment
jensmaurer
left a comment
There was a problem hiding this comment.
Split into two commits, please.
frederick-vs-ja
force-pushed
the
ios-typedef-names-no-def
branch
from
178fc43 to
67707d1
Compare
Contributor
Author
Done. @jensmaurer |
jensmaurer
approved these changes
Mar 25, 2026
jensmaurer
removed
the
changes requested
Member
|
@jwakely , please have another look. |
jwakely
approved these changes
Mar 26, 2026
Member
|
I don't really like those commit descriptions. The actual patches are good. @tkoeppe ? |
…treams A follows up to P0448R4.
This replaces the imprecise and informal phrase "define instances of class templates".
tkoeppe
force-pushed
the
ios-typedef-names-no-def
branch
from
67707d1 to
5735213
Compare
Contributor
|
@jensmaurer Reworded, PTAL? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's arguably wrong to say "define" because these typedef-names don't cause anything to be defined. Perhaps we should say that they designate class template specializations.
Fixes #8378.