Fix INSTALL_INTERFACE for Boost versioned-layout installs on Windows#183
Conversation
boost_install's __boost_install_update_include_directory expects
either a raw path or $<BUILD_INTERFACE:path> to replace with the
correct $<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>. When
INSTALL_INTERFACE was already set, the pattern match failed and
the versioned include path (include/boost-X_Y) was never applied.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe CMakeLists.txt was modified to reorganize how include directory interfaces are configured for the boost_capy target. The INSTALL_INTERFACE directive was removed from the common setup function and added separately in the standalone (non-superproject) installation branch. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
An automated preview of the documentation is available at https://183.capy.prtest3.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-02-23 23:00:51 UTC |
|
GCOVR code coverage report https://183.capy.prtest3.cppalliance.org/gcovr/index.html Build time: 2026-02-23 23:15:56 UTC |
boost_install's __boost_install_update_include_directory expects either a raw path or$<BUILD_INTERFACE:path> to replace with the correct $ <INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>. When INSTALL_INTERFACE was already set, the pattern match failed and the versioned include path (include/boost-X_Y) was never applied.
Summary by CodeRabbit