You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I checked the wxString container configuration with the Boinc project sources that use wxWidgets and I can not see false positives/negatives. There are now passedByValue messages like they are issued for std::string, but that seems valid. @orbitcowboy Do you have time to test this configuration against some projects or verify the changes directly? You are working on the wxwidgets.cfg so I just guess you have some projects for testing wxWidgets stuff :) If not we can let daca@home test it and see how it performs.
I checked the wxString container configuration with the Boinc project sources that use wxWidgets and I can not see false positives/negatives. There are now passedByValue messages like they are issued for std::string, but that seems valid. @orbitcowboy Do you have time to test this configuration against some projects or verify the changes directly? You are working on the wxwidgets.cfg so I just guess you have some projects for testing wxWidgets stuff :) If not we can let daca@home test it and see how it performs.
Many thanks for adding this configuration. This was already on my list too :-)
I have tested your PR with my wxWidgets projects and i did not see any effect. The results did not change.
Feel free to merge your PR after CI is OK. Then we can observe daca@home results.
Thanks for testing.
Master has issues currently that need to be resolved first, then a Travis analysis can be triggered again.
No changes in the results for your projects sounds good I guess. Then there should not be too many false positives/false negatives :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference: https://docs.wxwidgets.org/3.0/classwx_string.html