Skip to content

wxwidgets.cfg: Add container configuration for wxString#2109

Merged
versat merged 2 commits into
cppcheck-opensource:masterfrom
versat:wxwidgets_cfg_wxstring_container
Aug 23, 2019
Merged

wxwidgets.cfg: Add container configuration for wxString#2109
versat merged 2 commits into
cppcheck-opensource:masterfrom
versat:wxwidgets_cfg_wxstring_container

Conversation

@versat
Copy link
Copy Markdown
Collaborator

@versat versat commented Aug 22, 2019

@versat
Copy link
Copy Markdown
Collaborator Author

versat commented Aug 23, 2019

I checked the wxString container configuration with the Boinc project sources that use wxWidgets and I can not see false positives/negatives. There are now passedByValue messages like they are issued for std::string, but that seems valid.
@orbitcowboy Do you have time to test this configuration against some projects or verify the changes directly? You are working on the wxwidgets.cfg so I just guess you have some projects for testing wxWidgets stuff :) If not we can let daca@home test it and see how it performs.

Comment thread cfg/wxwidgets.cfg
@orbitcowboy
Copy link
Copy Markdown
Collaborator

I checked the wxString container configuration with the Boinc project sources that use wxWidgets and I can not see false positives/negatives. There are now passedByValue messages like they are issued for std::string, but that seems valid.
@orbitcowboy Do you have time to test this configuration against some projects or verify the changes directly? You are working on the wxwidgets.cfg so I just guess you have some projects for testing wxWidgets stuff :) If not we can let daca@home test it and see how it performs.

Many thanks for adding this configuration. This was already on my list too :-)
I have tested your PR with my wxWidgets projects and i did not see any effect. The results did not change.

Feel free to merge your PR after CI is OK. Then we can observe daca@home results.

@versat
Copy link
Copy Markdown
Collaborator Author

versat commented Aug 23, 2019

Thanks for testing.
Master has issues currently that need to be resolved first, then a Travis analysis can be triggered again.
No changes in the results for your projects sounds good I guess. Then there should not be too many false positives/false negatives :)

@versat versat merged commit 7f50642 into cppcheck-opensource:master Aug 23, 2019
@versat versat deleted the wxwidgets_cfg_wxstring_container branch August 23, 2019 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants