fix false positive of virtual function call

[nomick]

Cppcheck issues a warning if a virtual call is called from a constructor or destructor. If the method is just overridden and marked final, this is a false positive.

[chrchr-github]

Do you have a test case for your fix?

[nomick]

The following should be ok (giving a virtualCallInConstructor)

class T {
public:
    virtual void vOk() {}
};

class T2 : public T {
public:
    T2() { vOk(); }
    void vOk() override final {}
};

I am just not sure where to add a unit test.

[danmar]

You can add a unit test in testclass.cpp. If you search for "Dynamic binding is not used" in that file you can find some tests in virtualFunctionCallInConstructor. I suggest you add this test at the end of that function.

[nomick]

That was easy ;) Test verified to fail on current master. Works with patch...

[danmar]

lgtm. if CI succeeds I think this can be merged.

[firewave]

https://trac.cppcheck.net/ticket/9333 - how did this regress?

[danmar]

https://trac.cppcheck.net/ticket/9333 - how did this regress?

hmm not sure I think my comment in that ticket is valid. It should probably rely on CTU.