Fix #10569 FN: duplicateExpression with multiple strings compared#4087
Merged
Conversation
pfultz2
reviewed
May 7, 2022
danmar
reviewed
May 8, 2022
danmar
left a comment
danmar
left a comment
Collaborator
There was a problem hiding this comment.
hmm.. the message is not ideal.
| " (a == \"y\") ||\n" | ||
| " (a == \"42\")) {}\n" | ||
| "}\n"); | ||
| ASSERT_EQUALS("[test.cpp:1] -> [test.cpp:4]: (style) Same expression on both sides of '||'.\n" |
Collaborator
There was a problem hiding this comment.
This message is not technically 100% true. It would be nice if we could rephraze the message somehow.
Duplicate expressions 'a == "42"' in condition ?
danmar
reviewed
May 9, 2022
|
|
||
| const std::string& op = opTok ? opTok->str() : "&&"; | ||
| std::string msg = "Same expression on both sides of \'" + op + "\'"; | ||
| std::string msg = "Same expression " + (hasMultipleExpr ? "found multiple times in chain of \'" + op + "\' operators" : "on both sides of \'" + op + "\'"); |
Collaborator
There was a problem hiding this comment.
Better! I suggest that the expression is written also:
"Same expression " + (hasMultipleExpr ? ("'" + expr1 + "' found multiple time in chain...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.