Skip to content

LCppC backport: Replaced check for pipe() buffer size by ordinary CheckBufferOverrun#4183

Merged
orbitcowboy merged 1 commit into
cppcheck-opensource:mainfrom
PKEuS:cppcheck-bp4
Jun 19, 2022
Merged

LCppC backport: Replaced check for pipe() buffer size by ordinary CheckBufferOverrun#4183
orbitcowboy merged 1 commit into
cppcheck-opensource:mainfrom
PKEuS:cppcheck-bp4

Conversation

@PKEuS

@PKEuS PKEuS commented Jun 8, 2022

Copy link
Copy Markdown
Contributor

As a follow-up to the discussion in PR4143, I am starting to provide a few fixes/improvements from LCppC to cppcheck, starting with those I backported and sent do danmar a year ago, but were not applied to cppcheck for unknown reasons.

@PKEuS

PKEuS commented Jun 8, 2022

Copy link
Copy Markdown
Contributor Author

I tried to fix/update this rng file, but apparently I failed. Can someone please explain how this has to look like?

@danmar

danmar commented Jun 8, 2022

Copy link
Copy Markdown
Collaborator

Did you try this:

<optional>
    <attribute name="baseType"><text/></attribute>
</optional>

… provide required Library configuration option

Merged from LCppC.
@PKEuS

PKEuS commented Jun 8, 2022

Copy link
Copy Markdown
Contributor Author

Thanks, trying that out.

@danmar

danmar commented Jun 8, 2022

Copy link
Copy Markdown
Collaborator

👍 for replacing hard coded checking with configuration

@pfultz2

pfultz2 commented Jun 8, 2022

Copy link
Copy Markdown
Contributor

man/reference-cfg-format.md documentation should be updated about this new attribute.

@pfultz2

pfultz2 commented Jun 8, 2022

Copy link
Copy Markdown
Contributor

Also, with all these PRs, you should consider updating release-notes.txt with all these new features so it will be added to the notes for next release.

@danmar

danmar commented Jun 9, 2022

Copy link
Copy Markdown
Collaborator

Also, with all these PRs, you should consider updating release-notes.txt with all these new features so it will be added to the notes for next release.

yes. however for this PR there is no new checker so I guess the release-notes.txt can be kept.

@orbitcowboy
orbitcowboy merged commit 9eb16e1 into cppcheck-opensource:main Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants