Fix #9282 FP Unused private function

[chrchr-github]

No description provided.

[chrchr-github]

CI failure seems unrelated.

[firewave]

CI failure seems unrelated.

Yeah - upstream issue. See #4329 (comment) for some of my comments.

[chrchr-github]

The simplification noexcept -> noexcept (true) does not work so well, see the second test case. Why do we have that? At least one test case actually relies on it, but I don't know how.

[firewave]

The build has been fixed - please rebase.

[danmar]

The simplification noexcept -> noexcept (true) does not work so well, see the second test case. Why do we have that? At least one test case actually relies on it, but I don't know how.

We can remove that simplification

[danmar]

The simplification noexcept -> noexcept (true) does not work so well

stupid question: what is the difference?

[chrchr-github]

I thought you might know why it was done? If the simplification is removed, one or two test cases fails due to an AST error. So I thought it might be easier to just apply the simplification consistently.

[danmar]

The simplification was added here: 1d491bd

I believe the simplification was added because it's easier to handle one syntax. But yes it was not simplified properly. If we remove the simplification we must ensure that all code handles both types of syntax.
In theory I would prefer that we remove simplifications and handle the code as is properly if it's not too much handling required here and there in various places.