Skip to content

Fixed typo in checkautovariables.cpp: getPointerDepth()#4329

Merged
orbitcowboy merged 1 commit intocppcheck-opensource:mainfrom
umanamente:getPointerDepth_typo
Aug 4, 2022
Merged

Fixed typo in checkautovariables.cpp: getPointerDepth()#4329
orbitcowboy merged 1 commit intocppcheck-opensource:mainfrom
umanamente:getPointerDepth_typo

Conversation

@umanamente
Copy link
Copy Markdown
Contributor

Obvious typo

Copy link
Copy Markdown
Contributor

@pfultz2 pfultz2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@firewave
Copy link
Copy Markdown
Collaborator

install-qt-action is broken - I will take a look at that tomorrow. Judging from the commits the author had problems getting his own CI to work. There was no version bump. It seems there also was a change in the name of configuration variables a few months back without bumping the version essentially already breaking it back then.

@chrchr-github
Copy link
Copy Markdown
Collaborator

It seems we should improve test coverage of this function (getPointerDepth()).

@firewave
Copy link
Copy Markdown
Collaborator

firewave commented Aug 1, 2022

install-qt-action is broken - I will take a look at that tomorrow. Judging from the commits the author had problems getting his own CI to work. There was no version bump. It seems there also was a change in the name of configuration variables a few months back without bumping the version essentially already breaking it back then.

Somebody else filed a ticket and I chimed in: jurplel/install-qt-action#153

@firewave
Copy link
Copy Markdown
Collaborator

firewave commented Aug 2, 2022

The build has been fixed - please rebase.

@orbitcowboy orbitcowboy merged commit 460f635 into cppcheck-opensource:main Aug 4, 2022
@umanamente umanamente deleted the getPointerDepth_typo branch August 5, 2022 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants