feature/#88 suppress warnings based on symbol name and file

[davidramnero]

[danmar]

do I have to manually write the filename or symbol name?

[davidramnero]

do I have to manually write the filename or symbol name?

Filename will auto-fill based on the document being analyzed. There is a function that tries to guess symbol name based on the line affected (trying to parse out a function or variable name). The result of this will be set as a suggested symbol name filled into the text box, but can be edited manually

[danmar]

hmm the symbolname is written for warnings when available if xml output is used. there is a <symbol> element.

$ ./cppcheck --xml 1.c --enable=unusedFunction -q
<?xml version="1.0" encoding="UTF-8"?>
<results version="2">
    <cppcheck version="2.21 dev"/>
    <errors>
        <error id="unusedFunction" severity="style" msg="The function &apos;foo&apos; is never used." verbose="The function &apos;foo&apos; is never used." cwe="561">
            <location file="1.c" line="2" column="6"/>
            <symbol>foo</symbol>
        </error>
    </errors>
</results>

[davidramnero]

hmm the symbolname is written for warnings when available if xml output is used. there is a <symbol> element.

$ ./cppcheck --xml 1.c --enable=unusedFunction -q
<?xml version="1.0" encoding="UTF-8"?>
<results version="2">
    <cppcheck version="2.21 dev"/>
    <errors>
        <error id="unusedFunction" severity="style" msg="The function &apos;foo&apos; is never used." verbose="The function &apos;foo&apos; is never used." cwe="561">
            <location file="1.c" line="2" column="6"/>
            <symbol>foo</symbol>
        </error>
    </errors>
</results>

Aah okay nice, did not realise! Will use this instead

[davidramnero]

Okay, I updated it so that we use symbol from the XML. It is not always present, so currently I let the user edit the symbol name or enter something else manually (the symbol name from the XML is pre-filled if preset). We might want the flow to work differently, what do you think @danmar ?

[danmar]

would it be possible to have:

• if warning has no symbol then don't write anything about symbolname.
• if warning has symbol, add a checkbox so the user can select if he wants to suppress warnings for that symbol only or all such warnings. I.e. only suppress if symbolname is 'util_broken' or something like that.

[davidramnero]

Okay, now the action is sensitive to if a diagnostic has a symbol associated with it recieved from cppcheck. This affects the flow of creating the suppression as well as text displayed in UI:

[davidramnero]