llvm: expose token none constant - #1
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces support for the LLVM ConstantTokenNone constant in the Go bindings. It adds a new C binding function LLVMGoConstTokenNone in IRBindings.cpp and IRBindings.h, exposes it as the ConstTokenNone method on the Context struct in ir.go, and includes a comprehensive test suite in ir_test.go to verify its integration with coroutine intrinsics across different LLVM versions. No review comments were provided, so there is no additional feedback to address.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Summary
llvm::ConstantTokenNone::get(Context)asContext.ConstTokenNone()token nonellvm.coro.suspendand the version-appropriatellvm.coro.endsignatureThis is the missing primitive needed for LLVM 19 switched-resume coroutine lowering in llgo.
Validation
go test .with the default LLVM 19 configurationgo vet .