Honor minimum community size in architecture reports - #305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
min_community_sizereport option filter detailed architecture communities--min-community-size=1restores singleton presentationEvidence
Graphify does not delete singleton communities: it assigns each isolate to a one-node community, then omits communities below its default size threshold of 3 only from detailed reports. A synthetic execution confirmed all nodes remained assigned while thin communities were disclosed as omitted.
A real FastAPI graph measurement found 268 singleton communities, all with degree zero. It also found exact edges in some two-node communities, which demonstrates why small communities must remain queryable rather than being removed from
graph.json.Compatibility
This is a presentation-layer change using an existing option. It does not change graph schema, graph publication, community identity, query behavior, viewer data, or version numbers. Callers that need the previous full directory can set
min_community_sizeto 1.Verification
cargo fmt --all -- --checkcargo test -p compass-output --lockedcargo clippy -p compass-output --all-targets --all-features --locked -- -D warningscargo clippy --workspace --lib --bins --locked -- -D warningscargo test --workspace --lib --bins --locked./scripts/qualify_code_graph_v1.sh --fixtures-onlysh scripts/check_product_boundary.sh