fix(ci): guard the pantry-env evals in package.json too, which #107 missed - #111
Merged
Merged
Conversation
…issed #107 removed `eval "$(pantry env …)"` from 16 sites across five workflows and said so. It missed eight more in `package.json`, and `integration` found them: its "Run root verification" step runs `bun run verify`, which reaches `build:core`, which evals `pantry env`, which runs the workspace setup — ✗ Patch failed for ts-maps error: Cannot find package 'typescript' from …/packages/typescript/scripts — the same clobbered `node_modules`, one door further along. The failing step moved from "Build TypeScript SDK" to "Run root verification"; the cause did not change at all. Guarded rather than removed, because these are not the workflow's sites. In CI the pantry action puts `zig` on PATH, so the guard short-circuits and nothing runs a workspace setup. On a developer's machine `zig` is usually not on PATH, and the eval is exactly how these scripts have always made it available — that still happens, unchanged. `.github/CONTRIBUTING.md` documents activating pantry for a shell, and this keeps working for anyone who has not. Verified both directions: with `zig` on PATH the guard skips the eval and `bun run fmt:check` exits 0; without it, the eval runs as before.
✅ Binary Size Report
Size limits
|
✅ Binary load timeWhat this measures
Both binaries are measured interleaved on this runner and compared by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#107 removed
eval "$(pantry env …)"from 16 sites across five workflows and said so. It missed eight more inpackage.json, andintegrationon #108 found them.The "Run root verification" step runs
bun run verify→build:core→eval "$(pantry env …)"→ the workspace setup:Same clobbered
node_modules, one door further along. The failing step moved from "Build TypeScript SDK" to "Run root verification"; the cause did not change.Guarded, not removed
These are not the workflow's sites and they are not redundant the same way. In CI the pantry action puts
zigon PATH, socommand -v zigshort-circuits and no workspace setup runs. On a developer's machinezigis usually not on PATH, and this eval is how these scripts have always made it available — that path is unchanged.Verified both directions
zigon PATH → guard skips the eval,bun run fmt:checkexits 0.zigabsent → eval runs exactly as before.Unblocks #108, whose
integrationfailed on this.