Conversation
There was a problem hiding this comment.
Pull request overview
Adds Valkey-backed caching support in Craft Cloud, with a cache “cascade” setup so requests can use a layered cache configuration.
Changes:
- Switch cache component to use
craft\cachecascade\CascadeCachewith a primary cache (Valkey/Redis or DB) plus an in-processArrayCache. - Add Valkey endpoint resolution via SRV lookup (
CRAFT_CLOUD_CACHE_SRV), with a deprecated fallback toCRAFT_CLOUD_REDIS_URL. - Add
craftcms/yii2-cache-cascadeas a dependency.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/AppConfig.php |
Implements Valkey SRV resolution and configures cascade caching (primary + in-memory). |
composer.json |
Adds cache-cascade package dependency needed by the new cache component. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addev valkey support + cache cascade