Skip to content

Use server image dimensions for Cloud asset uploads#158

Merged
timkelty merged 3 commits into
3.xfrom
bugfix/exif-dimensions
Jun 3, 2026
Merged

Use server image dimensions for Cloud asset uploads#158
timkelty merged 3 commits into
3.xfrom
bugfix/exif-dimensions

Conversation

@timkelty
Copy link
Copy Markdown
Contributor

@timkelty timkelty commented Jun 3, 2026

Description

  • Stop trusting browser-supplied width and height for Cloud image uploads and replacements.
  • Read persisted image dimensions from the uploaded file on the server so EXIF-oriented JPEGs keep correct crop math.
  • Add unit coverage for image, non-image, and replacement upload dimension selection.
  • Update URL path joining in src/fs/Fs.php to use the current league/uri-components API.

Testing

  • Unit tests added for Cloud asset dimension selection behavior.
  • Full test suite passed locally, including phpstan and code style checks.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eae3f4f529

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/controllers/AssetsController.php
@timkelty timkelty merged commit 4dc67b6 into 3.x Jun 3, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant