[6.x] Fixes for Codex findings#19252
Merged
Merged
Conversation
📚 Storybook previews@craftcms/cp — open Storybook No changed components detected in this Storybook. resources/js — open Storybook No changed components detected in this Storybook. |
riasvdv
marked this pull request as ready for review
July 15, 2026 20:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Told Codex to find bugs or inconsistencies and it found some, most of these are edge cases and small fixes but still worth doing, another prompt would probably find more stuff, but I thought this was enough for one PR 😅
Verified and reviewed the code for each of these manually between each commit.
One behavior change is that logout is now a
POSTinstead of aGET, which is what's actually recommended asGETshould be idempotent and some browsers prefetch links which would cause an unintended logout.Edit: adjusted the registration to
Route::anysoGETrequests still work for backwards compatibility.