Skip to content

Add missing WidgetInterface bridge methods to legacy Widget base class - #19375

Merged
riasvdv merged 1 commit into
6.xfrom
fix/legacy-widget-interface-methods
Aug 5, 2026
Merged

Add missing WidgetInterface bridge methods to legacy Widget base class#19375
riasvdv merged 1 commit into
6.xfrom
fix/legacy-widget-interface-methods

Conversation

@lukeholder

@lukeholder lukeholder commented Aug 5, 2026

Copy link
Copy Markdown
Member

The legacy craft\base\Widget adapter implemented WidgetInterface but never got getType(), getIcon(), getDisplayName(), and getMaxColspan(), unlike the new native Widget base class. Any legacy-style widget errored on instantiation.

Related issues

The legacy craft\base\Widget adapter implemented WidgetInterface but
never got getType(), getIcon(), getDisplayName(), and getMaxColspan(),
unlike the new native Widget base class. Any legacy-style widget was
left effectively abstract and fatal-errored on instantiation.

@riasvdv riasvdv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phpstan is unrelated, I'll fix that on the 6.x branch

@riasvdv
riasvdv marked this pull request as ready for review August 5, 2026 12:01
@riasvdv
riasvdv merged commit b3a35dc into 6.x Aug 5, 2026
16 of 17 checks passed
@lukeholder
lukeholder deleted the fix/legacy-widget-interface-methods branch August 5, 2026 14:12
brandonkelly added a commit that referenced this pull request Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants