Fix SKU format not resolving {id} for new variants - #4354
Merged
Conversation
updateSku() ran in beforeValidate()/beforeSave(), before the variant
had an ID, so a skuFormat referencing {id} produced a truncated SKU
on create. Mirrors the existing afterAssignedId() fix for title
formats (#4308), but regenerates the SKU since updateSku() only
fills in blank SKUs.
[ci skip]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skuFormatvalues containing{id}produced a truncated SKU (e.g.SKU-4012-) for new variants, becauseupdateSku()runs before the variant has an ID.updateTitle()got the same fix forvariantTitleFormatin [5.7] Update variant title after record is saved #4308, viaafterAssignedId(). This applies the same idea to SKUs.