Skip to content
This repository was archived by the owner on May 21, 2025. It is now read-only.

Remove blackfire#83

Merged
timkelty merged 5 commits intocraftcms:mainfrom
jawys:remove-blackfire
Sep 3, 2023
Merged

Remove blackfire#83
timkelty merged 5 commits intocraftcms:mainfrom
jawys:remove-blackfire

Conversation

@jawys
Copy link
Copy Markdown
Contributor

@jawys jawys commented Aug 29, 2023

Description

This removes

  • the blackfire* scripts from Dockerfiles && from repo
  • a typo in the Makefile
  • unnecessary RUN steps due to buildkit features (first set USER, then mkdir+chown+cd using WORKDIR)

Related issues

Closes #55

Comment thread 8.0/Dockerfile
@timkelty
Copy link
Copy Markdown
Collaborator

unnecessary RUN steps due to buildkit features (first set USER, then mkdir+chown+cd using WORKDIR)

this was news to me, thanks!

@jawys jawys requested a review from timkelty August 29, 2023 12:48
Comment thread 8.0/Dockerfile
@jawys
Copy link
Copy Markdown
Contributor Author

jawys commented Sep 1, 2023

@timkelty You marked the conversations as resolved, however I see that you requested changes. What do you want me to do?

@timkelty
Copy link
Copy Markdown
Collaborator

timkelty commented Sep 1, 2023

@jawys all good – i'll merge when I'm back at a keyboard!

@timkelty timkelty merged commit 4b7cedd into craftcms:main Sep 3, 2023
@jawys jawys deleted the remove-blackfire branch September 3, 2023 14:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Blackfire APM attempting to run even if not configured

2 participants