auto-capitalize keywords while typing #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaudum
force-pushed
the
h/autocapitalize
branch
from
44da61e to
452787f
Compare
Current coverage is 80.68% (diff: 88.31%)@@ master #169 diff @@
==========================================
Files 16 16
Lines 1750 1817 +67
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1408 1466 +58
- Misses 342 351 +9
Partials 0 0
|
mfussenegger
approved these changes
Jan 24, 2017
Member
mfussenegger
left a comment
mfussenegger
left a comment
There was a problem hiding this comment.
lgtm if it doesn't break copy and paste in some odd way
chaudum
force-pushed
the
h/autocapitalize
branch
2 times, most recently
from
1ea8c9f to
edd2855
Compare
memcmp
approved these changes
Jan 25, 2017
chaudum
force-pushed
the
h/autocapitalize
branch
from
edd2855 to
d10093c
Compare
|
nice. However, I would like to have a setting that can be used to activate/deactivate this feature. |
|
@chaudum noticed an issue that causes partly-capitalization of a word that is not registered as a keyword. e.g. if settings are queried. cr> SELECT SETtings FROM sys.cluster;
|
Contributor
Author
|
@mikethebeer addressed your comments /cc @autophagy |
added cli argument and command for auto-capitalization undo capitalization if necessary words that start with a sql keyword should not be capitalized once you continue typing the word. the behaviour is the following: s -> s se -> se sel -> sel sele -> sele selec -> selec select -> SELECT selecti -> selecti selectio -> selectio selection -> selection
chaudum
force-pushed
the
h/autocapitalize
branch
from
96d18f2 to
dc61826
Compare
|
Changes Unknown when pulling dc61826 on h/autocapitalize into ** on master**. |
3 similar comments
|
Changes Unknown when pulling dc61826 on h/autocapitalize into ** on master**. |
|
Changes Unknown when pulling dc61826 on h/autocapitalize into ** on master**. |
|
Changes Unknown when pulling dc61826 on h/autocapitalize into ** on master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.