Skip to content

Conversation

@amotl
Copy link
Member

@amotl amotl commented Jun 5, 2025

About

Add a product card page for RisingWave, to be accompanied by relevant tutorials.

Preview

https://cratedb-guide--210.org.readthedocs.build/integrate/risingwave/

References

Details

image

@amotl amotl requested a review from hlcianfagna June 5, 2025 15:43
@coderabbitai
Copy link

coderabbitai bot commented Jun 5, 2025

Walkthrough

A new section for RisingWave integration was added to the ETL documentation. This includes a dedicated index page introducing RisingWave, its features, example usage, and a tutorial reference for streaming data from Apache Iceberg tables to CrateDB using RisingWave. No code or API changes were made.

Changes

File(s) Change Summary
docs/integrate/etl/index.md Added a "RisingWave" section with a toctree link to the new RisingWave integration documentation.
docs/integrate/risingwave/index.md Added a new documentation page describing RisingWave integration, features, examples, and tutorial references.

Poem

In the docs a wave has risen high,
Streaming data swiftly by.
With Iceberg cool and CrateDB neat,
Real-time queries can’t be beat!
ETL flows with rabbit cheer,
New integrations now appear.
🐇🌊


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@amotl amotl marked this pull request as ready for review June 5, 2025 15:45
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (2)
docs/integrate/risingwave/index.md (2)

21-21: Provide descriptive alt text for the image.

The image on line 21 lacks alt text, which is important for accessibility and SEO.

🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

21-21: Images should have alternate text (alt text)
null

(MD045, no-alt-text)


70-71: Replace hard tabs with spaces in SQL code.

Lines 70–71 use hard tabs for indentation; convert them to spaces to comply with MD010 guidelines.

🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

70-70: Hard tabs
Column: 1

(MD010, no-hard-tabs)


71-71: Hard tabs
Column: 1

(MD010, no-hard-tabs)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e047a76 and 70b5db0.

📒 Files selected for processing (2)
  • docs/integrate/etl/index.md (1 hunks)
  • docs/integrate/risingwave/index.md (1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
docs/integrate/risingwave/index.md

21-21: Images should have alternate text (alt text)
null

(MD045, no-alt-text)


70-70: Hard tabs
Column: 1

(MD010, no-hard-tabs)


71-71: Hard tabs
Column: 1

(MD010, no-hard-tabs)

⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Build docs
🔇 Additional comments (1)
docs/integrate/etl/index.md (1)

185-192: RisingWave section integration looks good.

The new toctree entry aligns with existing ETL sections and correctly points to ../risingwave/index.

@amotl amotl force-pushed the risingwave-card branch from 70b5db0 to a57e264 Compare June 5, 2025 15:51
@amotl amotl changed the title RisingWave: Add index page (product card) RisingWave: Add index page Jun 5, 2025
@amotl amotl force-pushed the risingwave-card branch from 9447607 to 2c9cab0 Compare June 5, 2025 16:51
@amotl amotl requested review from hammerhead and karynzv June 5, 2025 16:52
@amotl amotl requested a review from hlcianfagna June 6, 2025 08:37
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

♻️ Duplicate comments (1)
docs/integrate/risingwave/index.md (1)

81-83: Add missing reference definition for the tutorial link.

The link

[Stream processing from Iceberg tables to CrateDB using RisingWave]

at line 83 is never defined, causing a broken link. Please append a reference at the end, for example:

+[Stream processing from Iceberg tables to CrateDB using RisingWave]: https://cratedb-guide--210.org.readthedocs.build/integrate/risingwave/stream-processing-iceberg-cratedb/

Adjust the URL as needed.

Also applies to: 91-94

🧹 Nitpick comments (5)
docs/integrate/risingwave/index.md (5)

5-8: Improve accessibility by adding alt text to the logo image.

The logo is currently embedded as ![](...), which provides no descriptive alt text. Consider updating it to:

[![](https://www.risingwave.com/...){w=180px}](https://www.risingwave.com/)

-[![](https://www.risingwave.com/_next/static/media/risingwave-logo-black-text.11ccd229.svg){w=180px}](https://www.risingwave.com/)
+![RisingWave logo](https://www.risingwave.com/_next/static/media/risingwave-logo-black-text.11ccd229.svg){w=180px}](https://www.risingwave.com/)

This ensures screen readers convey the purpose of the image.


35-38: Verify rubric directive syntax.

The block

:::{rubric} RisingWave
:::
Load an Apache Iceberg table, and serve it as materialized view.

opens and immediately closes the rubric container, so the content may not render inside it. Either wrap the text within the rubric block:

:::{rubric} RisingWave
Load an Apache Iceberg table, and serve it as a materialized view.
:::

or replace with a standard subheading (### RisingWave).


59-63: Apply the same rubric fix for “CrateDB.”

The rubric snippet around CrateDB uses the same pattern:

:::{rubric} CrateDB
:::
Converge into a CrateDB table…

Ensure the content is included within the rubric container or switch to a regular heading.


69-75: Refine wording for tone consistency.

The phrase “a little Python event processor” is informal. For clarity and consistency, consider:

-However, because this does not currently support CrateDB, a little Python event processor
+However, because this does not currently support CrateDB, a simple Python event processor

95-95: Ensure a trailing newline.

Add a newline at end of file to satisfy POSIX conventions and avoid warnings in CI.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 247b387 and 99a2c68.

📒 Files selected for processing (1)
  • docs/integrate/risingwave/index.md (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Build docs

@amotl
Copy link
Member Author

amotl commented Jun 6, 2025

@coderabbitai: The {rubric} syntax is correct, as employed by MyST. Please learn that.

@coderabbitai
Copy link

coderabbitai bot commented Jun 6, 2025

Tip

For best results, initiate chat on the files or code changes.

@amotl Thank you for the clarification! I've noted that the {rubric} syntax is indeed correct in MyST Markdown. I appreciate you helping me improve my understanding of the MyST syntax variations.

🐰📚
Thoughtfully taking notes...


✏️ Learnings added
Learnt from: amotl
URL: https://github.com/crate/cratedb-guide/pull/210

Timestamp: 2025-06-06T08:46:08.674Z
Learning: The `{rubric}` syntax (with single curly braces) is correct and valid in MyST Markdown, as employed by MyST.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.


🧠 Learnings used
Learnt from: amotl
PR: crate/cratedb-guide#204
File: docs/integrate/mcp/cratedb-mcp.md:12-21
Timestamp: 2025-05-18T13:39:52.044Z
Learning: In MyST Markdown, the correct syntax for rubric directives is to close the directive immediately after the title, rather than wrapping the content:
```
:::{rubric} Title
:::

Content goes here (outside the directive)
```

Learnt from: amotl
PR: crate/cratedb-guide#204
File: docs/integrate/mcp/cratedb-mcp.md:3-8
Timestamp: 2025-05-18T13:39:58.391Z
Learning: In MyST Markdown, the rubric directive is used for informal headings and doesn't wrap content. The correct syntax is:
```
:::{rubric} Title
:::
```
followed by the content outside of the directive. This differs from admonition blocks which do wrap their content.

Learnt from: amotl
PR: crate/cratedb-guide#204
File: docs/integrate/mcp/cratedb-mcp.md:3-8
Timestamp: 2025-05-18T13:39:58.391Z
Learning: In MyST Markdown, the correct syntax for rubric directives in the CrateDB documentation is:
```
:::{rubric} Title
:::
```
followed by the content outside of the directive. This is different from other admonition blocks where content is typically wrapped inside the directive.

@coderabbitai
Copy link

coderabbitai bot commented Jun 6, 2025

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

@amotl Thank you for the clarification! I'll examine the files and add this to my knowledge base.

ʕ •ᴥ•ʔ 📚


🏁 Script executed:

#!/bin/bash
# Examine the new RisingWave documentation file to see the rubric syntax being used
cat docs/integrate/risingwave/index.md

Length of output: 2942


@amotl Thank you for the clarification! I can see in the RisingWave documentation file that the :::{rubric} syntax is indeed being used correctly throughout - for "RisingWave", "CrateDB", and "Tutorials" sections. The syntax properly closes the directive immediately after the title, with content appearing outside the directive block, exactly as MyST specifies.

ʕ •ᴥ•ʔ 📖✨


✏️ Learnings added
Learnt from: amotl
URL: https://github.com/crate/cratedb-guide/pull/210

Timestamp: 2025-06-06T08:46:34.533Z
Learning: In MyST Markdown, the `{rubric}` syntax is correct as employed by MyST for rubric directives.

Learnt from: amotl
URL: https://github.com/crate/cratedb-guide/pull/210

Timestamp: 2025-06-06T08:46:34.533Z
Learning: Rubric directives (`{rubric}` and `:::{rubric}`) are correct and valid MyST Markdown syntax for creating informal headings.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.


🧠 Learnings used
Learnt from: amotl
PR: crate/cratedb-guide#204
File: docs/integrate/mcp/cratedb-mcp.md:12-21
Timestamp: 2025-05-18T13:39:52.044Z
Learning: In MyST Markdown, the correct syntax for rubric directives is to close the directive immediately after the title, rather than wrapping the content:
```
:::{rubric} Title
:::

Content goes here (outside the directive)
```

Learnt from: amotl
PR: crate/cratedb-guide#204
File: docs/integrate/mcp/cratedb-mcp.md:3-8
Timestamp: 2025-05-18T13:39:58.391Z
Learning: In MyST Markdown, the rubric directive is used for informal headings and doesn't wrap content. The correct syntax is:
```
:::{rubric} Title
:::
```
followed by the content outside of the directive. This differs from admonition blocks which do wrap their content.

@amotl amotl merged commit 721e9cb into main Jun 6, 2025
3 checks passed
@amotl amotl deleted the risingwave-card branch June 6, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants