-
Notifications
You must be signed in to change notification settings - Fork 1
RisingWave: Add index page #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughA new section for RisingWave integration was added to the ETL documentation. This includes a dedicated index page introducing RisingWave, its features, example usage, and a tutorial reference for streaming data from Apache Iceberg tables to CrateDB using RisingWave. No code or API changes were made. Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
docs/integrate/risingwave/index.md (2)
21-21: Provide descriptive alt text for the image.The image on line 21 lacks alt text, which is important for accessibility and SEO.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
21-21: Images should have alternate text (alt text)
null(MD045, no-alt-text)
70-71: Replace hard tabs with spaces in SQL code.Lines 70–71 use hard tabs for indentation; convert them to spaces to comply with MD010 guidelines.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
70-70: Hard tabs
Column: 1(MD010, no-hard-tabs)
71-71: Hard tabs
Column: 1(MD010, no-hard-tabs)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
docs/integrate/etl/index.md(1 hunks)docs/integrate/risingwave/index.md(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
docs/integrate/risingwave/index.md
21-21: Images should have alternate text (alt text)
null
(MD045, no-alt-text)
70-70: Hard tabs
Column: 1
(MD010, no-hard-tabs)
71-71: Hard tabs
Column: 1
(MD010, no-hard-tabs)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Build docs
🔇 Additional comments (1)
docs/integrate/etl/index.md (1)
185-192: RisingWave section integration looks good.The new toctree entry aligns with existing ETL sections and correctly points to
../risingwave/index.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
♻️ Duplicate comments (1)
docs/integrate/risingwave/index.md (1)
81-83: Add missing reference definition for the tutorial link.The link
[Stream processing from Iceberg tables to CrateDB using RisingWave]at line 83 is never defined, causing a broken link. Please append a reference at the end, for example:
+[Stream processing from Iceberg tables to CrateDB using RisingWave]: https://cratedb-guide--210.org.readthedocs.build/integrate/risingwave/stream-processing-iceberg-cratedb/Adjust the URL as needed.
Also applies to: 91-94
🧹 Nitpick comments (5)
docs/integrate/risingwave/index.md (5)
5-8: Improve accessibility by adding alt text to the logo image.The logo is currently embedded as
, which provides no descriptive alt text. Consider updating it to:[{w=180px}](https://www.risingwave.com/)→
-[{w=180px}](https://www.risingwave.com/) +{w=180px}](https://www.risingwave.com/)This ensures screen readers convey the purpose of the image.
35-38: Verify rubric directive syntax.The block
:::{rubric} RisingWave ::: Load an Apache Iceberg table, and serve it as materialized view.opens and immediately closes the
rubriccontainer, so the content may not render inside it. Either wrap the text within the rubric block::::{rubric} RisingWave Load an Apache Iceberg table, and serve it as a materialized view. :::or replace with a standard subheading (
### RisingWave).
59-63: Apply the same rubric fix for “CrateDB.”The
rubricsnippet around CrateDB uses the same pattern::::{rubric} CrateDB ::: Converge into a CrateDB table…Ensure the content is included within the rubric container or switch to a regular heading.
69-75: Refine wording for tone consistency.The phrase “a little Python event processor” is informal. For clarity and consistency, consider:
-However, because this does not currently support CrateDB, a little Python event processor +However, because this does not currently support CrateDB, a simple Python event processor
95-95: Ensure a trailing newline.Add a newline at end of file to satisfy POSIX conventions and avoid warnings in CI.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/integrate/risingwave/index.md(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Build docs
|
@coderabbitai: The |
|
Tip For best results, initiate chat on the files or code changes. @amotl Thank you for the clarification! I've noted that the 🐰📚 ✏️ Learnings added
🧠 Learnings used |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain@amotl Thank you for the clarification! I'll examine the files and add this to my knowledge base. ʕ •ᴥ•ʔ 📚 🏁 Script executed: Length of output: 2942 @amotl Thank you for the clarification! I can see in the RisingWave documentation file that the ʕ •ᴥ•ʔ 📖✨ ✏️ Learnings added
🧠 Learnings used |
About
Add a product card page for RisingWave, to be accompanied by relevant tutorials.
Preview
https://cratedb-guide--210.org.readthedocs.build/integrate/risingwave/
References
Details