-
Notifications
You must be signed in to change notification settings - Fork 1
Sweep: Fix Docker invocation on Windows/PowerShell #460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughDocumentation files across multiple guides now consistently quote the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes This is a highly homogeneous, repetitive formatting change applied consistently across documentation files with no logic or control-flow modifications. All edits follow the identical pattern of shell quoting. Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
> The workaround for Docker is to include each setting in single > quotes, like `'-Cdiscovery.type=single-node'`. Otherwise, users will receive an error like this: NullPointerException: Cannot invoke "String.isEmpty()"
1e1967e to
85620a3
Compare
'-Cdiscovery.type=single-node' to fix start on Windows
matriv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx!
About
@matriv discovered that when using Docker on Windows/PowerShell, users must quote
-Cparameters.docker run --rm --publish=4200:4200 --publish=5432:5432 docker.io/crate '-Cdiscovery.type=single-node'References
-Cdiscovery.type=single-node#325-Cdiscovery.type=single-node#390 (comment)/cc @karynzv, @surister, @seut, @michaelkremmel, @grbade