Replace zope testrunner with plain unittest#260
Merged
mfussenegger merged 2 commits intomasterfrom Feb 3, 2026
Merged
Conversation
mfussenegger
force-pushed
the
j/testrunner
branch
from
e4eabbf to
97ce3f0
Compare
mfussenegger
force-pushed
the
j/testrunner
branch
from
97ce3f0 to
0198fdf
Compare
This was referenced Feb 2, 2026
seut
approved these changes
Feb 3, 2026
| super().__init__(methodName) | ||
| self.container = None | ||
| self.name = 'crate' | ||
| self.image = "crate/crate:test" |
Member
There was a problem hiding this comment.
could use TAG, right?
Suggested change
| self.image = "crate/crate:test" | |
| self.image = TAG |
Member
Author
There was a problem hiding this comment.
Good catch - removed the self.image property altogether.
mfussenegger
force-pushed
the
j/testrunner
branch
from
d0b7006 to
f7da1fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The layer functionality isn't really needed given that all tests are in one module - can use a
setUpModule/tearDownModuleinstead.unittest module has better integration in editors (e.g. to trigger individual tests).
And not depending on another test runner gets rid of dependencies which create dependency bump noise and busywork