incorporate new vocabulary-theme header and footer components, with appropriate assets and stylings#496
Merged
possumbilities merged 19 commits intomainfrom Nov 15, 2023
Merged
Conversation
…ooter, disable icon style clashes
✅ Deploy Preview for creativecommons-chooser ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
vocabulary-theme header and footer components
vocabulary-theme header and footer componentsvocabulary-theme header and footer components, with appropriate assets and stylings
Contributor
Author
|
Investigating the built version's static JS not firing. Consider this back in "draft" for now. |
Contributor
Author
|
All tests are passing, and the localized |
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
vocabulary-legacyintostaticdirvocabulary-legacyso it can be overridden more easily with newvocabularyvocabularyfromvocabulary-themeinto thestaticdirsrc/styles/vocab.scssheadercomponent from the newvocabulary-themefootercomponent from the newvocabulary-themevocabularyjs expand functionality intomountfunction ofheadercomponent/docswith latest changesScreenshots
Checklist
Update index.md).mainormaster).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin