Skip to content

incorporate new vocabulary-theme header and footer components, with appropriate assets and stylings#496

Merged
possumbilities merged 19 commits intomainfrom
header-footer
Nov 15, 2023
Merged

incorporate new vocabulary-theme header and footer components, with appropriate assets and stylings#496
possumbilities merged 19 commits intomainfrom
header-footer

Conversation

@possumbilities
Copy link
Contributor

@possumbilities possumbilities commented Nov 2, 2023

Description

  • isolates vocabulary-legacy into static dir
  • alters some stylings from vocabulary-legacy so it can be overridden more easily with new vocabulary
  • localizes new vocabulary from vocabulary-theme into the static dir
  • adds localized patch styling to src/styles/vocab.scss
  • adds the global header component from the new vocabulary-theme
  • adds the global footer component from the new vocabulary-theme
  • adds new vocabulary js expand functionality into mount function of header component
  • adjust cypress auto-scroll Y position tests to accommodate the added height of the header component.
  • builds project in /docs with latest changes

Screenshots

Screen Shot 2023-11-13 at 3 53 07 PM

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@netlify
Copy link

netlify bot commented Nov 2, 2023

Deploy Preview for creativecommons-chooser ready!

Name Link
🔨 Latest commit 0ab59b8
🔍 Latest deploy log https://app.netlify.com/sites/creativecommons-chooser/deploys/6554e92b84d8c200084c1c91
😎 Deploy Preview https://deploy-preview-496--creativecommons-chooser.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@possumbilities possumbilities self-assigned this Nov 2, 2023
@possumbilities possumbilities marked this pull request as ready for review November 13, 2023 21:54
@possumbilities possumbilities requested review from a team as code owners November 13, 2023 21:54
@possumbilities possumbilities requested review from kgodey and removed request for a team November 13, 2023 21:54
@possumbilities possumbilities changed the title Header footer incorporate new vocabulary-theme header and footer components Nov 13, 2023
@possumbilities possumbilities changed the title incorporate new vocabulary-theme header and footer components incorporate new vocabulary-theme header and footer components, with appropriate assets and stylings Nov 13, 2023
@possumbilities possumbilities removed request for a team and kgodey November 13, 2023 21:56
@possumbilities
Copy link
Contributor Author

Investigating the built version's static JS not firing. Consider this back in "draft" for now.

@possumbilities
Copy link
Contributor Author

possumbilities commented Nov 14, 2023

All tests are passing, and the localized vocabulary.js behaviors load at the correct spot in the stack, and works both in tests and on the Netlify deploy preview.

Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

@possumbilities possumbilities merged commit f7ba713 into main Nov 15, 2023
@possumbilities possumbilities deleted the header-footer branch November 15, 2023 16:08
@b7r3333

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants