Add call logging dashboard#1
Merged
Merged
Conversation
This was referenced Mar 6, 2026
creativeux
added a commit
that referenced
this pull request
Jul 1, 2026
Address PR #28 review nit #1: TestFetchLineDiagnostics only asserted degradation for the registration sub-call. Add the cases that moved out of the old service tests when orchestration relocated to the repository: sub-account-fail → None, did-routing-fail → None, servers-info-fail → empty POP map (IDs unresolved), and all-four-fail → fully degraded. None raise. Also record the two non-blocking review follow-ups (dedupe CDR error classification onto classify_provider_error; diagnostics-route defense-in-depth) in the rollout trace for a later wave. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
creativeux
added a commit
that referenced
this pull request
Jul 1, 2026
Address PR #29 review should-fix #1: the empty-accounts read-back path collapsed two distinct RemediationResult.detail strings into one, emitting "...max_expiry is still after update" (double space) instead of the original "...could not retrieve sub-account after update" — an observable /api change. - MaxExpiryOutcome.actual is now str | None (None = read-back returned no account); the service maps None → "could not retrieve sub-account after update", a value mismatch → "max_expiry is still {actual} after update". - Restore the service-level empty-verify detail assertion (review #2) and fix the repo test to assert actual is None. - Nit: restore exc_info=True on the router's unreachable/upstream remediation log lines (dropped stack context). Full suite 708 passed; ruff clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getCDR), repository (mapping + stats), service (concurrent fetch + merge), router (GET /api/callswith validation)useCallLoghook,CallLogpage with stats cards, All/Missed filter tabs, formatted phone numbers, relative timestamps, disposition badges, date range picker, client-side paginationreact-router-domwith nav bar and/callsroutequality-gatestandard enforcing lint/format/test checks before task completionTest plan
backend/.venv/bin/pytest backend/tests/ -q— 34 passedbackend/.venv/bin/ruff check backend/— all passedbackend/.venv/bin/ruff format --check backend/— all passedcd frontend && pnpm test— 11 passed🤖 Generated with Claude Code