Skip to content

fix: notice url fetch logic - #1589

Merged
tipusinghaw merged 1 commit into
mainfrom
fix/consent-notice-url
Mar 24, 2026
Merged

fix: notice url fetch logic#1589
tipusinghaw merged 1 commit into
mainfrom
fix/consent-notice-url

Conversation

@tipusinghaw

@tipusinghaw tipusinghaw commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

What

Fixed the notice URL fetch logic

Signed-off-by: Tipu_Singh <tipu.singh@ayanworks.com>
@coderabbitai

coderabbitai Bot commented Mar 24, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: dfa07f0e-0b60-437d-8a50-ae2924873da1

📥 Commits

Reviewing files that changed from the base of the PR and between 52250e6 and 57eeed6.

📒 Files selected for processing (1)
  • apps/oid4vc-verification/src/oid4vc-verification.helper.ts

📝 Walkthrough

Walkthrough

The fetchConsentNotice function was updated to retrieve the consent notice URL from a nested property structure (consent_notice.consentNoticeUrl) instead of a top-level property (consentNoticeUrl), reflecting a change in the expected API response format.

Changes

Cohort / File(s) Summary
Consent Notice Fetch
apps/oid4vc-verification/src/oid4vc-verification.helper.ts
Updated property access path to retrieve consent notice URL from nested consent_notice.consentNoticeUrl structure instead of top-level consentNoticeUrl.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A nested path revealed so clear,
No longer flat, the structure's here!
One helper function finds its way,
To deeper truths in JSON's day.
Consent notice calls anew,
One small hop for code that's true! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: notice url fetch logic' is directly related to the main change—fixing the consent notice URL fetch logic by updating the response structure.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/consent-notice-url

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

Copy link
Copy Markdown

@tipusinghaw
tipusinghaw requested a review from sujitaw March 24, 2026 05:07
@tipusinghaw tipusinghaw self-assigned this Mar 24, 2026
@tipusinghaw
tipusinghaw merged commit ab28429 into main Mar 24, 2026
8 checks passed
@tipusinghaw
tipusinghaw deleted the fix/consent-notice-url branch March 24, 2026 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants