feat: lazy import chromadb#4226
Closed
gabemilani wants to merge 1 commit into
Closed
Conversation
gabemilani
force-pushed
the
feat/lazy-import-chromadb
branch
from
4b496c5 to
a0204f9
Compare
greysonlalonde
suggested changes
Jan 12, 2026
greysonlalonde
left a comment
greysonlalonde
left a comment
Contributor
There was a problem hiding this comment.
I'm all for the type checking changes, I think we should look at moving imports from module level a little more though
gabemilani
force-pushed
the
feat/lazy-import-chromadb
branch
from
a0204f9 to
d79162c
Compare
gabemilani
force-pushed
the
feat/lazy-import-chromadb
branch
from
d79162c to
4637754
Compare
Member
Author
|
Holding on this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChromaDB was imported at module level, causing slow imports even when not used. This was causing unnecessary delays.
The changes from this PR are moving the imports to within where it's needed and using
TYPE_CHECKINGwhere it's just for typing hints.