fix: escape single quotes in LanceDB delete() to prevent SQL injection#4835
Open
SinzoL wants to merge 2 commits intocrewAIInc:mainfrom
Open
fix: escape single quotes in LanceDB delete() to prevent SQL injection#4835SinzoL wants to merge 2 commits intocrewAIInc:mainfrom
SinzoL wants to merge 2 commits intocrewAIInc:mainfrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Contributor
|
This PR is stale because it has been open for 45 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In LanceDBStorage.delete(), the fast-path for record_ids directly interpolates IDs into the SQL expression without escaping single quotes. A record ID containing a single quote would break SQL syntax or allow injection. The touch_records() method already correctly escapes with replace("'", "''"). Apply the same escaping in delete(). Fixes #4850
Note
Low Risk
Low risk: a small, localized change to escaping of record IDs in
LanceDBStorage.delete()to prevent malformed queries/SQL injection; behavior should only differ for IDs containing single quotes.Overview
Hardens LanceDB memory deletions against injection/syntax errors. In
LanceDBStorage.delete(), therecord_idsfast-path and the category/metadata deletion path now escape single quotes in IDs (matchingtouch_records()/update()) before building theid IN (...)predicate.Written by Cursor Bugbot for commit 1dcb6be. This will update automatically on new commits. Configure here.