Skip to content

fix: escape single quotes in LanceDB delete() to prevent SQL injection #4835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SinzoL wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: escape single quotes in LanceDB delete() to prevent SQL injection #4835

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0017de
fix: escape single quotes in delete() record_ids to prevent SQL injec…
SinzoL Mar 13, 2026
1dcb6be
fix: also escape single quotes in second delete path (category/metada…
SinzoL Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/crewai/src/crewai/memory/storage/lancedb_storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,8 @@ def delete(
with self._write_lock, self._file_lock():
if record_ids and not (categories or metadata_filter):
before = self._table.count_rows()
ids_expr = ", ".join(f"'{rid}'" for rid in record_ids)
safe_ids = [str(rid).replace("'", "''") for rid in record_ids]
ids_expr = ", ".join(f"'{rid}'" for rid in safe_ids)
Comment thread
cursor[bot] marked this conversation as resolved.
self._do_write("delete", f"id IN ({ids_expr})")
return before - self._table.count_rows()
if categories or metadata_filter:
Expand All @@ -460,7 +461,8 @@ def delete(
if not to_delete:
return 0
before = self._table.count_rows()
ids_expr = ", ".join(f"'{rid}'" for rid in to_delete)
safe_ids = [str(rid).replace("'", "''") for rid in to_delete]
ids_expr = ", ".join(f"'{rid}'" for rid in safe_ids)
self._do_write("delete", f"id IN ({ids_expr})")
return before - self._table.count_rows()
conditions = []
Expand Down