Remove redundant CEL text helper + agent repo guidance#6528
Conversation
📝 WalkthroughWalkthroughThe custom CEL ChangesCEL text removal and interpolation guidance
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
lib/crewai/tests/test_flow_from_definition.py (1)
1300-1323: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueRename stale test:
test_agent_action_renders_text_custom_expression_input.The test name still references "text_custom_expression" but the test body now uses direct
${...}interpolation. Rename to reflect the actual behavior being tested, e.g.,test_agent_action_renders_interpolated_input.♻️ Proposed rename
-def test_agent_action_renders_text_custom_expression_input( +def test_agent_action_renders_interpolated_input( monkeypatch: pytest.MonkeyPatch, ):🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@lib/crewai/tests/test_flow_from_definition.py` around lines 1300 - 1323, Rename the test function test_agent_action_renders_text_custom_expression_input to reflect that it verifies direct interpolated input, using a name such as test_agent_action_renders_interpolated_input; leave the test implementation unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@lib/crewai/tests/test_flow_from_definition.py`:
- Around line 1300-1323: Rename the test function
test_agent_action_renders_text_custom_expression_input to reflect that it
verifies direct interpolated input, using a name such as
test_agent_action_renders_interpolated_input; leave the test implementation
unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: f769e597-583e-42ec-988f-68ca9594add6
📒 Files selected for processing (6)
lib/cli/src/crewai_cli/templates/declarative_flow/AGENTS.mdlib/cli/tests/test_create_flow.pylib/crewai/src/crewai/flow/expressions.pylib/crewai/src/crewai/flow/templates/flow_definition_skill.md.j2lib/crewai/tests/test_flow_definition.pylib/crewai/tests/test_flow_from_definition.py
This commit removes the redundant CEL text helper, in favor of the easier interpolation syntax.
1ca012f to
d9207cf
Compare
This commit removes the redundant CEL text helper, in favor of the easier interpolation syntax.