ci: report required test check names on non-code PRs - #6822
Merged
Conversation
Skipped matrix jobs never post status for branch-protection names like tests (3.10). Add lightweight skip jobs with the same names so Actions-only and docs-only PRs can merge without waiting forever. Co-authored-by: Rip&Tear <theCyberTech@users.noreply.github.com>
📝 WalkthroughWalkthroughChangesCI skip check reporting
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
theCyberTech
marked this pull request as ready for review
August 5, 2026 08:49
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/tests.yml (1)
132-134: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick winDisable fail-fast for both skip matrices.
The default can cancel other matrix legs after one failure. Add
fail-fast: falseso every required version check can report independently. (docs.github.com)
.github/workflows/tests.yml#L132-L134: Addfail-fast: falsetotests-skip..github/workflows/type-checker.yml#L86-L88: Addfail-fast: falsetotype-checker-skip.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/tests.yml around lines 132 - 134, Set fail-fast to false for the tests-skip matrix in .github/workflows/tests.yml at lines 132-134 and the type-checker-skip matrix in .github/workflows/type-checker.yml at lines 86-88, so all required version checks run independently.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/workflows/tests.yml:
- Around line 132-134: Set fail-fast to false for the tests-skip matrix in
.github/workflows/tests.yml at lines 132-134 and the type-checker-skip matrix in
.github/workflows/type-checker.yml at lines 86-88, so all required version
checks run independently.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: ffa17f59-bb9c-43ee-a0c0-74b93037b7c6
📒 Files selected for processing (2)
.github/workflows/tests.yml.github/workflows/type-checker.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skipped matrix jobs never post status for branch-protection check names like
tests (3.10). On Actions-only / docs-only PRs those required checks hang forever as "Expected — Waiting for status to be reported."tests-skipandtype-checker-skipjobs that use the same names (tests (3.10)–tests (3.13), etc.) and succeed whencode != trueFollow-up to #6818.