Skip to content

ci: report required test check names on non-code PRs - #6822

Merged
theCyberTech merged 2 commits into
mainfrom
cursor/skip-python-ci-on-actions-c1bc
Aug 5, 2026
Merged

ci: report required test check names on non-code PRs#6822
theCyberTech merged 2 commits into
mainfrom
cursor/skip-python-ci-on-actions-c1bc

Conversation

@theCyberTech

Copy link
Copy Markdown
Member

Skipped matrix jobs never post status for branch-protection check names like tests (3.10). On Actions-only / docs-only PRs those required checks hang forever as "Expected — Waiting for status to be reported."

  • Add lightweight tests-skip and type-checker-skip jobs that use the same names (tests (3.10)tests (3.13), etc.) and succeed when code != true
  • Wire them into the summary jobs so non-code PRs still get a green required status without running the Python matrix

Follow-up to #6818.

Open in Web Open in Cursor 

Skipped matrix jobs never post status for branch-protection names like
tests (3.10). Add lightweight skip jobs with the same names so Actions-only
and docs-only PRs can merge without waiting forever.

Co-authored-by: Rip&Tear <theCyberTech@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings August 5, 2026 08:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Changes

CI skip check reporting

Layer / File(s) Summary
Tests skip matrix
.github/workflows/tests.yml
Adds tests-skip for Python 3.10–3.13 when code changes are absent. The tests summary job waits for both test paths.
Type-checker skip matrix
.github/workflows/type-checker.yml
Adds type-checker-skip for Python 3.10–3.13 when code changes are absent. The type-checker summary job waits for both type-check paths.

Suggested reviewers: greysonlalonde

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the CI change that reports required test check names for non-code pull requests.
Description check ✅ Passed The description directly explains the skipped CI jobs and their purpose for non-code pull requests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/skip-python-ci-on-actions-c1bc

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the size/S label Aug 5, 2026
@theCyberTech
theCyberTech marked this pull request as ready for review August 5, 2026 08:49

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/workflows/tests.yml (1)

132-134: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick win

Disable fail-fast for both skip matrices.

The default can cancel other matrix legs after one failure. Add fail-fast: false so every required version check can report independently. (docs.github.com)

  • .github/workflows/tests.yml#L132-L134: Add fail-fast: false to tests-skip.
  • .github/workflows/type-checker.yml#L86-L88: Add fail-fast: false to type-checker-skip.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/tests.yml around lines 132 - 134, Set fail-fast to false
for the tests-skip matrix in .github/workflows/tests.yml at lines 132-134 and
the type-checker-skip matrix in .github/workflows/type-checker.yml at lines
86-88, so all required version checks run independently.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In @.github/workflows/tests.yml:
- Around line 132-134: Set fail-fast to false for the tests-skip matrix in
.github/workflows/tests.yml at lines 132-134 and the type-checker-skip matrix in
.github/workflows/type-checker.yml at lines 86-88, so all required version
checks run independently.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ffa17f59-bb9c-43ee-a0c0-74b93037b7c6

📥 Commits

Reviewing files that changed from the base of the PR and between fae6340 and bb50760.

📒 Files selected for processing (2)
  • .github/workflows/tests.yml
  • .github/workflows/type-checker.yml

Copilot AI review requested due to automatic review settings August 5, 2026 09:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Vidit-Ostwal Vidit-Ostwal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@theCyberTech
theCyberTech merged commit a3351d1 into main Aug 5, 2026
28 checks passed
@theCyberTech
theCyberTech deleted the cursor/skip-python-ci-on-actions-c1bc branch August 5, 2026 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants