fix(state): persist json checkpoints as utf-8 - #6858
Open
Ghraven wants to merge 1 commit into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthrough
ChangesUTF-8 checkpoint persistence
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
JsonProviderwrites and reads checkpoint JSON using the platform default text encoding. On systems where the default encoding is not UTF-8, checkpoint payloads containing non-ASCII state can fail to persist or restore consistently.Before / after
Before, sync and async checkpoint reads/writes relied on the process/platform default encoding.
After, both paths use
encoding="utf-8"explicitly for checkpoint files, matching the JSON/state portability expectation.Verification
uv run pytest lib/crewai/tests/test_checkpoint.py::TestJsonProviderFork::test_checkpoint_round_trips_utf8_text lib/crewai/tests/test_checkpoint.py::TestJsonProviderFork::test_acheckpoint_round_trips_utf8_text -n 0 --allowed-hosts=127.0.0.1,localhostgit diff --checkI also tried the broader
TestJsonProviderForkslice locally on Windows. The new UTF-8 tests passed, but the broader slice still hits existing Windows-local assumptions unrelated to this change: two tests assert POSIX-style/main/and/fork/exp1/separators, and one teardown encountered a locked temporary SQLite file.