Skip to content

update conformance-testdata-configuration for v2#35

Merged
jbw976 merged 1 commit into
crossplane:mainfrom
jbw976:modernize
Sep 17, 2025
Merged

update conformance-testdata-configuration for v2#35
jbw976 merged 1 commit into
crossplane:mainfrom
jbw976:modernize

Conversation

@jbw976

@jbw976 jbw976 commented Sep 17, 2025

Copy link
Copy Markdown
Member

Description of your changes

This PR updates the contents of the crossplane/conformance-testdata-configuration test configuration package that is used in the TestConfiguration conformance test case:

  • convert to function pipeline from native patch and transform
  • use cluster scoped v2 XRD
  • use latest provider-nop with ClusterNopResource
  • add more tests and cleanup to verify new function dependencies succeed

This was missed in #31 because the TestConfiguration test was always failing due to no longer existing dependencies and we needed a build from main after #31 to then have a test package to run this test case on and realize it doesn't work 😂

I have:

  • Read and followed conformance's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

I've built, pushed, and tested a test configuration package with my personal account: index.docker.io/jbw976/conformance-testdata-configuration:v2.0.0-cf.1-rc.0-20250917

❯ crossplane xpkg build -f testdata/configuration -o conformance.xpkg
❯ crossplane xpkg push -f conformance.xpkg index.docker.io/jbw976/conformance-testdata-configuration:v2.0.0-cf.1-rc.0-20250917

❯ go test -v -run TestConfiguration ./tests
=== RUN   TestConfiguration
    configuration_test.go:66: Created configuration "crossplane-conformance-configuration"
=== RUN   TestConfiguration/BecomesInstalledAndHealthy
    configuration_test.go:102: Testing that the configuration's Healthy and Installed status conditions become 'True'.
    configuration_test.go:109: Configuration "crossplane-conformance-configuration" is not yet Healthy
    configuration_test.go:109: Configuration "crossplane-conformance-configuration" is not yet Healthy
    configuration_test.go:118: Configuration "crossplane-conformance-configuration" is Healthy and Installed
=== RUN   TestConfiguration/RevisionBecomesHealthyAndDeploysObjects
    configuration_test.go:126: Testing that the configuration's revision's Healthy status conditions become 'True', and that it deploys its objects.
    configuration_test.go:140: Found revision "crossplane-conformance-configuration-408562dc4169" owned by configuration "crossplane-conformance-configuration"
    configuration_test.go:147: Revision "crossplane-conformance-configuration-408562dc4169" is RevisionHealthy
    configuration_test.go:168: Revision "crossplane-conformance-configuration-408562dc4169" created CompositeResourceDefinition "clusterconformances.test.crossplane.io"
    configuration_test.go:168: Revision "crossplane-conformance-configuration-408562dc4169" created Composition "crossplane-conformance"
=== RUN   TestConfiguration/DependenciesBecomesInstalledAndHealthy
    configuration_test.go:182: Testing that the configuration's dependencies' Healthy and Installed status conditions become 'True'.
    configuration_test.go:202: Provider "crossplane-contrib-provider-nop" is Healthy and Installed
    configuration_test.go:227: Function "crossplane-contrib-function-patch-and-transform" is Healthy and Installed
=== NAME  TestConfiguration
    configuration_test.go:91: Cleaning up configuration "crossplane-conformance-configuration".
    configuration_test.go:98: Deleted configuration "crossplane-conformance-configuration"
    configuration_test.go:80: Cleaning up function "crossplane-contrib-function-patch-and-transform".
    configuration_test.go:87: Deleted function "crossplane-contrib-function-patch-and-transform"
    configuration_test.go:69: Cleaning up provider "crossplane-contrib-provider-nop".
    configuration_test.go:76: Deleted provider "crossplane-contrib-provider-nop"
--- PASS: TestConfiguration (20.08s)
    --- PASS: TestConfiguration/BecomesInstalledAndHealthy (20.01s)
    --- PASS: TestConfiguration/RevisionBecomesHealthyAndDeploysObjects (0.01s)
    --- PASS: TestConfiguration/DependenciesBecomesInstalledAndHealthy (0.01s)
PASS
ok  	github.com/crossplane/conformance/tests	20.512s

- convert to function pipeline from native patch and transform
- use cluster scoped v2 XRD
- use latest provider-nop with ClusterNopResource
- add more tests and cleanup to verify new function dependencies succeed

Signed-off-by: Jared Watts <jbw976@gmail.com>
@jbw976 jbw976 merged commit 662bdc0 into crossplane:main Sep 17, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants