chore(deps): bump Go to 1.25.9 [security] (release-1.20)#965
chore(deps): bump Go to 1.25.9 [security] (release-1.20)#965phisco wants to merge 1 commit intocrossplane:release-1.20from
Conversation
govulncheck reports five reachable stdlib vulnerabilities on this branch at the current Go 1.23.7 toolchain, in crypto/x509, crypto/tls, html/ template and net/url. Both Go 1.23 and Go 1.24 went end-of-life before the April 2026 security batch (1.23 on 2025-08-12 when 1.25.0 shipped, 1.24 on 2026-02-10 when 1.26.0 shipped). The fixes only exist in Go 1.25.9 and 1.26.2, and no backport will be made. This commit therefore does a two-minor-version bump to 1.25.9, in both the Earthfile toolchain and the go.mod directive. The separate toolchain directive is dropped since the go directive now matches. Signed-off-by: Philippe Scorsolini <5697904+phisco@users.noreply.github.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing as won't-fix. Bumping Go to 1.25.9 on this branch hits two compounding issues that each
Given release-1.20 is three minor versions behind main and the 5 reachable Consumers on release-1.20 who care about the stdlib fixes should upgrade |
…ports This unblocks the security dep bumps queued for release-1.20: * crossplane#918 - golang.org/x/net v0.45.0 (CVE-2025-47911, CVE-2025-58190; first patched version is v0.45.0 which declares `go 1.24.0` in its go.mod) * crossplane#971 - google.golang.org/grpc v1.79.3 (CVE-2026-33186; also declares `go 1.24.0`) Both deps require `go >= 1.24.0` so `go mod download` fails on this branch under the pinned `GOTOOLCHAIN=local` with Go 1.23.7. Bumping the `go` directive to `1.24.0` and the toolchain to the latest 1.24.x patch (1.24.13) is the minimum change needed to unblock the backports. Staying on the 1.24 line (not 1.25) deliberately avoids the golangci-lint v1 -> v2 migration and `x/tools v0.24.0` incompatibility that blocked the earlier 1.25 attempt (see crossplane#965). `go mod tidy`, `go build ./...`, and `go vet ./...` are all clean; no code changes are needed. Signed-off-by: Philippe Scorsolini <5697904+phisco@users.noreply.github.com>
Description of your changes
Mirrors #961 for release-1.20, adapted for Earthly.
govulncheckreports 5 reachable stdlib vulnerabilities on this branchwith the current Go 1.23.7 toolchain (same CVE set as release-2.0 and
release-2.1):
Both Go 1.23 and Go 1.24 went end-of-life before the April 2026
security batch (1.23 EOL: 2025-08-12 when 1.25.0 shipped; 1.24 EOL:
2026-02-10 when 1.26.0 shipped). The latest 1.23 release (1.23.12)
does not contain these fixes and none will be backported. Fixing them
requires moving off the 1.23 line entirely.
This PR therefore jumps straight to Go 1.25.9 — a two-minor bump —
updating both the Earthfile toolchain and the `go.mod` directive.
The now-redundant `toolchain go1.23.7` line is dropped.
Alternatives worth considering before merging:
archived, we could mark these CVEs as won't-fix on this branch.
could bump only `Earthfile`'s `GO_VERSION` and leave `go.mod`
untouched, keeping library consumers unaffected.
Fixes #
I have:
Added or updated unit tests.Linked a PR or a docs tracking issue to document this change.Added `backport release-x.y` labels to auto-backport this PR.