chore: bump Go toolchain to 1.24.13 on release-1.20#977
Merged
phisco merged 2 commits intocrossplane:release-1.20from Apr 17, 2026
Merged
chore: bump Go toolchain to 1.24.13 on release-1.20#977phisco merged 2 commits intocrossplane:release-1.20from
phisco merged 2 commits intocrossplane:release-1.20from
Conversation
…ports This unblocks the security dep bumps queued for release-1.20: * crossplane#918 - golang.org/x/net v0.45.0 (CVE-2025-47911, CVE-2025-58190; first patched version is v0.45.0 which declares `go 1.24.0` in its go.mod) * crossplane#971 - google.golang.org/grpc v1.79.3 (CVE-2026-33186; also declares `go 1.24.0`) Both deps require `go >= 1.24.0` so `go mod download` fails on this branch under the pinned `GOTOOLCHAIN=local` with Go 1.23.7. Bumping the `go` directive to `1.24.0` and the toolchain to the latest 1.24.x patch (1.24.13) is the minimum change needed to unblock the backports. Staying on the 1.24 line (not 1.25) deliberately avoids the golangci-lint v1 -> v2 migration and `x/tools v0.24.0` incompatibility that blocked the earlier 1.25 attempt (see crossplane#965). `go mod tidy`, `go build ./...`, and `go vet ./...` are all clean; no code changes are needed. Signed-off-by: Philippe Scorsolini <5697904+phisco@users.noreply.github.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The Go 1.24 toolchain bump enables golangci-lint's usetesting check on t.Context(), introduced in Go 1.24. Replace context.Background() with t.Context() in pkg/parser/fuzz_test.go to satisfy the linter. Signed-off-by: Philippe Scorsolini <5697904+phisco@users.noreply.github.com>
lsviben
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Minimal Go-only bump on
release-1.20to unblock the queued securitydependency updates. No code changes.
Why
The security bumps currently failing CI on this branch each declare
go 1.24.0in their owngo.mod:golang.org/x/net->v0.45.0(CVE-2025-47911 quadratic parsingDoS in
html.Parse, CVE-2025-58190 infinite parsing loop; GitHubadvisory confirms
first_patched_version: 0.45.0, no usableintermediate version on the
go 1.23line).google.golang.org/grpc->v1.79.3(CVE-2026-33186 authorizationbypass via missing leading slash in
:path).With
release-1.20pinned atgo 1.23.0/toolchain go1.23.7andEarthly set to
GOTOOLCHAIN=local,go mod downloadfails for both PRswith:
which cascades to
unit-tests,lint,check-diff, andcodeql.What
go.mod:go 1.23.0->go 1.24.0,toolchain go1.23.7->go1.24.13(latest 1.24 patch).
Earthfile:GO_VERSION=1.23.7->1.24.13.go mod tidyproduces no dependency changes.go build ./...andgo vet ./...are clean on the branch.Why 1.24 and not 1.25
An earlier attempt to bump to 1.25 on this branch (#965) was closed as
won't-fix because it required:
golangci-lintv1 -> v2 migration (the pinnedv1.64.8refusesto lint code declaring
go 1.25).x/tools v0.24.0incompatibilitywith Go 1.25 (
invalid array length -delta * delta).Staying on the 1.24 line avoids both.
golangci-lint v1.64.8was builtagainst Go 1.24 and continues to work, and
x/tools v0.24.0iscompatible with Go 1.24. The 5 reachable stdlib CVEs flagged on this
branch remain won't-fix (Go 1.24 is also EOL and does not backport
them); this PR is scoped strictly to unblocking the dep bumps above.
Fixes #
I have:
Run(local Earthly setup unavailable; CI will run it)earthly +reviewableto ensure this PR is ready for review.Added or updated unit tests.Linked a PR or a docs tracking issue to document this change.Addedbackport release-x.ylabels to auto-backport this PR.