Fix set name key conversion on set switch - #1357
Closed
LAfricain wants to merge 2 commits into
Closed
Conversation
added 2 commits
August 1, 2026 20:33
Set names with spaces or other XML-special characters caused a parser error on startup when used as XML tag names (e.g. 'Short set' became <parallel_set_Short set> which is invalid XML). Fix: automatically convert spaces to underscores when storing set names as XML keys, and convert back for display in the UI. New helpers in settings.c: name_to_key(name) - convert display name to XML key (space -> _) key_to_name(key) - convert XML key to display name (_ -> space) Fixes crash on startup when a parallel set name contains a space.
When switching sets via the ComboBox, the displayed name (with spaces) was being stored directly in settings.xml instead of the XML key (with underscores), causing a mismatch on next startup. Apply name_to_key() before storing parallel_set_current and before calling get_parallel_set() when switching sets.
Contributor
Author
|
I hope this works! I've run several tests and it seems to be working... |
Contributor
|
sigh Try again. |
Contributor
|
@karlkleinpaste Not sure what you're doing to pull a patch file like that and apply it. You can just directly check out his branch. Two main ways: If you do not have the Github client installed
If you DO have the Github client installed
|
Contributor
I do what I've always done wtih GH PRs: I add ".patch" to the url, save that patch file, and apply it in a clean branch from master (or in my local master itself, if I don't want to bother creating a temp local branch, because cleaning up the results of an applied patch is easy) with |
Contributor
|
I'd suggest choosing either the native Git method or setting up the Github CLI client. Either one makes testing PRs a far smoother experience! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When switching sets via the ComboBox, the displayed name (with spaces)
was being stored directly in settings.xml instead of the XML key
(with underscores), causing a mismatch on next startup.
Apply name_to_key() before storing parallel_set_current and before
calling get_parallel_set() when switching sets.